Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4385)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 1704793002: Remove kDisableDownloadNotification and stop compiling shelf code on (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/notification/download_notification_manager.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 0a297d2116bd4a67bd2bed82ea1b9fbfa9a1556f..fe712afecadda8bae996f22bf89c237a1c40ca89 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -1429,13 +1429,14 @@ bool DownloadsSetShelfEnabledFunction::RunSync() {
extension(), params->enabled);
}
+#if !defined(OS_CHROMEOS)
BrowserList* browsers = BrowserList::GetInstance();
if (browsers) {
for (BrowserList::const_iterator iter = browsers->begin();
iter != browsers->end(); ++iter) {
const Browser* browser = *iter;
DownloadService* current_service =
- DownloadServiceFactory::GetForBrowserContext(browser->profile());
+ DownloadServiceFactory::GetForBrowserContext(browser->profile());
if (((current_service == service) ||
(current_service == incognito_service)) &&
browser->window()->IsDownloadShelfVisible() &&
@@ -1443,6 +1444,7 @@ bool DownloadsSetShelfEnabledFunction::RunSync() {
browser->window()->GetDownloadShelf()->Close(DownloadShelf::AUTOMATIC);
}
}
+#endif
if (params->enabled &&
((manager && !service->IsShelfEnabled()) ||
« no previous file with comments | « chrome/browser/download/notification/download_notification_manager.cc ('k') | chrome/browser/ui/browser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698