Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: BUILD.gn

Issue 1704763002: [GN] Add -Wno-unused-result on Linux and Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/rules.gni") 8 import("//build/config/android/rules.gni")
9 } 9 }
10 10
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 "/wd4068", # Unknown pragmas. 60 "/wd4068", # Unknown pragmas.
61 "/wd4267", # Conversion from size_t on 64-bits. 61 "/wd4267", # Conversion from size_t on 64-bits.
62 "/wd4996", # Deprecated functions. 62 "/wd4996", # Deprecated functions.
63 ] 63 ]
64 } else if (is_linux || is_android) { 64 } else if (is_linux || is_android) {
65 cflags += [ 65 cflags += [
66 # Since ICU wants to internally use its own deprecated APIs, don't 66 # Since ICU wants to internally use its own deprecated APIs, don't
67 # complain about it. 67 # complain about it.
68 "-Wno-deprecated-declarations", 68 "-Wno-deprecated-declarations",
69 "-Wno-unused-function", 69 "-Wno-unused-function",
70
71 # fread is used in putil.cpp without checking the return value.
72 "-Wno-unused-result",
70 ] 73 ]
71 } 74 }
72 if (is_clang) { 75 if (is_clang) {
73 cflags += [ 76 cflags += [
74 # ICU uses its own deprecated functions. 77 # ICU uses its own deprecated functions.
75 "-Wno-deprecated-declarations", 78 "-Wno-deprecated-declarations",
76 # ICU prefers `a && b || c` over `(a && b) || c`. 79 # ICU prefers `a && b || c` over `(a && b) || c`.
77 "-Wno-logical-op-parentheses", 80 "-Wno-logical-op-parentheses",
78 # ICU has some `unsigned < 0` checks. 81 # ICU has some `unsigned < 0` checks.
79 "-Wno-tautological-compare", 82 "-Wno-tautological-compare",
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 sources = [ 619 sources = [
617 "android/icudtl_dat.S", 620 "android/icudtl_dat.S",
618 ] 621 ]
619 } else { 622 } else {
620 assert(false, "No icu data for this platform") 623 assert(false, "No icu data for this platform")
621 } 624 }
622 defines = [ "U_HIDE_DATA_SYMBOL" ] 625 defines = [ "U_HIDE_DATA_SYMBOL" ]
623 } 626 }
624 } 627 }
625 } 628 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698