Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1704743002: Revert of Clean up public interface of AttachmentBrokerUnprivileged. (Closed)

Created:
4 years, 10 months ago by erikchen
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up public interface of AttachmentBrokerUnprivileged. (patchset #6 id:120001 of https://codereview.chromium.org/1679763002/ ) Reason for revert: failures on Chromium Memory FYI: http://build.chromium.org/p/chromium.memory.fyi/ Failure notification for "memory test: remoting" on "Chromium Mac (valgrind)(2)". Please see if the failures are related to your commit and take appropriate actions (e.g. revert, update suppressions, notify sheriff, etc.). For more info on the memory waterfall please see these links: http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff http://dev.chromium.org/developers/how-tos/using-valgrind http://dev.chromium.org/developers/how-tos/using-valgrind/threadsanitizer By the way, the current memory sheriff is on the CC list. http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28valgrind%29%282%29/builds/37788 Original issue's description: > Clean up public interface of AttachmentBrokerUnprivileged. > > In the old interface, a static factory method returns a scoped_ptr, and the > caller had to manage the lifetime. Since this is a global object with minimal > memory footprint, and is required to outlive every IPC::Channel, it's much > easier for the global to never be destroyed. This also matches the interface for > AttachmentBrokerPrivileged. > > BUG=584297 > > Committed: https://crrev.com/11fea2242b3a197993dbd5a1f977f9a31c6b98e4 > Cr-Commit-Position: refs/heads/master@{#375674} TBR=tsepez@chromium.org,avi@chromium.org,mseaborn@chromium.org,sergeyu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=584297 Committed: https://crrev.com/346a38381d14199e8bf62b8aff4b3e28948e0398 Cr-Commit-Position: refs/heads/master@{#375739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -128 lines) Patch
M components/nacl/broker/nacl_broker_listener.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M components/nacl/loader/nacl_listener.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/child/child_thread_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M ipc/attachment_broker.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ipc/attachment_broker.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged.h View 1 chunk +10 lines, -8 lines 0 comments Download
M ipc/attachment_broker_unprivileged.cc View 3 chunks +12 lines, -56 lines 0 comments Download
M remoting/host/desktop_process.h View 2 chunks +4 lines, -0 lines 0 comments Download
M remoting/host/desktop_process.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
erikchen
Created Revert of Clean up public interface of AttachmentBrokerUnprivileged.
4 years, 10 months ago (2016-02-17 01:20:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704743002/1
4 years, 10 months ago (2016-02-17 01:22:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 01:25:35 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 01:26:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/346a38381d14199e8bf62b8aff4b3e28948e0398
Cr-Commit-Position: refs/heads/master@{#375739}

Powered by Google App Engine
This is Rietveld 408576698