Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704723002: DevTools: add input event instrumentation test (Closed)

Created:
4 years, 10 months ago by caseq
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: add input event instrumentation test BUG=554215 Committed: https://crrev.com/e99c42679051cd91ef92155bb7f190a9405acedc Cr-Commit-Position: refs/heads/master@{#375802} Committed: https://crrev.com/cfbb3fafaf1631d04658eaa80b265c2a4e0242bf Cr-Commit-Position: refs/heads/master@{#376220}

Patch Set 1 : #

Patch Set 2 : fixed screenshot tests #

Patch Set 3 : speculative attempt to fix MacOS 10.6 flakiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -25 lines) Patch
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 1 2 7 chunks +78 lines, -11 lines 0 comments Download
A chrome/test/data/devtools/latency_info.html View 1 2 1 chunk +105 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/TestBase.js View 3 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Tests.js View 1 3 chunks +58 lines, -13 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
caseq
4 years, 10 months ago (2016-02-17 00:00:10 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2016-02-17 01:10:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704723002/20001
4 years, 10 months ago (2016-02-17 01:14:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/169008)
4 years, 10 months ago (2016-02-17 02:17:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704723002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704723002/40001
4 years, 10 months ago (2016-02-17 03:20:12 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-17 05:49:58 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e99c42679051cd91ef92155bb7f190a9405acedc Cr-Commit-Position: refs/heads/master@{#375802}
4 years, 10 months ago (2016-02-17 05:51:26 UTC) #14
henrika (OOO until Aug 14)
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/1705533003/ by henrika@chromium.org. ...
4 years, 10 months ago (2016-02-17 10:39:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704723002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704723002/60001
4 years, 10 months ago (2016-02-18 17:33:46 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 10 months ago (2016-02-18 19:15:17 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:16:52 UTC) #23
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cfbb3fafaf1631d04658eaa80b265c2a4e0242bf
Cr-Commit-Position: refs/heads/master@{#376220}

Powered by Google App Engine
This is Rietveld 408576698