Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1704663002: Add tests to validate assumptions made by summaries about type inference. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests to validate assumptions made by summaries about type inference. The summary code assumes that type inference is never done on initializing formals, constructor parameters, parameters of static methods, or parameters of top level functions. This CL adds tests that will fail if strong mode ever starts inferring parameter types from default parameters, rendering these assumptions wrong. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b5b7a7618cc277e59678301585cb9e507634ae46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-16 21:14:50 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-16 21:16:42 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-16 22:00:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b5b7a7618cc277e59678301585cb9e507634ae46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698