Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1704653004: libfuzzer: Add pdfium XFA fuzzers (Closed)

Created:
4 years, 10 months ago by Oliver Chang
Modified:
4 years, 10 months ago
Reviewers:
aizatsky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

libfuzzer: Add pdfium XFA fuzzers Also includes dicts. The XML dict is currently is a copy of the libxml dict, which I suspect may not be very effective. It might still be interesting just to get it running on CF before I build a better dict. BUG=587126 R=aizatsky@chromium.org Committed: https://crrev.com/2bc61daa5674521d2ed61713319b631e165a4c59 Cr-Commit-Position: refs/heads/master@{#375744}

Patch Set 1 #

Patch Set 2 : add missing import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, --1 lines) Patch
M testing/libfuzzer/fuzzers/BUILD.gn View 1 2 chunks +19 lines, -0 lines 0 comments Download
A testing/libfuzzer/fuzzers/dicts/pdf_fm2js.dict View 1 chunk +59 lines, -0 lines 0 comments Download
A + testing/libfuzzer/fuzzers/dicts/pdf_xml.dict View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Oliver Chang
ptal
4 years, 10 months ago (2016-02-17 00:24:30 UTC) #2
aizatsky
lgtm
4 years, 10 months ago (2016-02-17 00:37:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704653004/1
4 years, 10 months ago (2016-02-17 00:42:21 UTC) #5
Oliver Chang
whoops. Mike, mind taking a quick look at PS#2?
4 years, 10 months ago (2016-02-17 00:52:49 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704653004/20001
4 years, 10 months ago (2016-02-17 00:55:36 UTC) #9
aizatsky
LGTM But long term, is there a better place to put pdfium fuzzers into?
4 years, 10 months ago (2016-02-17 00:59:13 UTC) #10
Oliver Chang
On 2016/02/17 00:59:13, aizatsky wrote: > LGTM > > But long term, is there a ...
4 years, 10 months ago (2016-02-17 01:04:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704653004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704653004/20001
4 years, 10 months ago (2016-02-17 01:11:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 01:42:42 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2bc61daa5674521d2ed61713319b631e165a4c59 Cr-Commit-Position: refs/heads/master@{#375744}
4 years, 10 months ago (2016-02-17 01:44:09 UTC) #18
Lei Zhang
4 years, 10 months ago (2016-02-17 01:55:16 UTC) #19
Message was sent while issue was closed.
On 2016/02/17 01:04:03, Oliver Chang wrote:
> On 2016/02/17 00:59:13, aizatsky wrote:
> > LGTM
> > 
> > But long term, is there a better place to put pdfium fuzzers into?
> 
> Thanks!
> 
> Hmm, a subdir in //pdf might be a good place in the long run. Lei, is that the
> right place to have this?

If you want to stick them in a directory like pdf/pdfium/fuzzer, I don't mind.

Powered by Google App Engine
This is Rietveld 408576698