Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704603002: Change signature of SkSpecialImage::draw to take SkScalars (Closed)

Created:
4 years, 10 months ago by robertphillips
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change signature of SkSpecialImage::draw to take SkScalars Committed: https://skia.googlesource.com/skia/+/e8c34974c42b302d78c5cc8c7dcfb36956256baa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/core/SkSpecialImage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkSpecialImage.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M src/core/SkSpecialSurface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/SpecialImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
robertphillips
4 years, 10 months ago (2016-02-16 18:43:08 UTC) #3
Stephen White
LGTM
4 years, 10 months ago (2016-02-16 19:43:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704603002/1
4 years, 10 months ago (2016-02-16 19:44:21 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 20:08:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704603002/1
4 years, 10 months ago (2016-02-16 20:09:03 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 20:09:39 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e8c34974c42b302d78c5cc8c7dcfb36956256baa

Powered by Google App Engine
This is Rietveld 408576698