Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1704573002: tuned skiaserve's png output for better performance (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : formatting #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M gyp/skiaserve.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 3 chunks +32 lines, -7 lines 1 comment Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704573002/1
4 years, 10 months ago (2016-02-16 17:41:40 UTC) #3
ethannicholas
4 years, 10 months ago (2016-02-16 17:43:24 UTC) #5
joshualitt
On 2016/02/16 17:43:24, ethannicholas wrote: lgtm + nit
4 years, 10 months ago (2016-02-16 17:45:08 UTC) #6
joshualitt
nit https://codereview.chromium.org/1704573002/diff/1/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (right): https://codereview.chromium.org/1704573002/diff/1/tools/skiaserve/skiaserve.cpp#newcode113 tools/skiaserve/skiaserve.cpp:113: for (png_size_t y = 0; y < height; ...
4 years, 10 months ago (2016-02-16 17:45:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704573002/20001
4 years, 10 months ago (2016-02-16 17:47:45 UTC) #10
mtklein
https://codereview.chromium.org/1704573002/diff/20001/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (right): https://codereview.chromium.org/1704573002/diff/20001/tools/skiaserve/skiaserve.cpp#newcode116 tools/skiaserve/skiaserve.cpp:116: png_set_filter(png, 0, PNG_NO_FILTERS); If you're interested in trying allowing ...
4 years, 10 months ago (2016-02-16 17:48:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/6218)
4 years, 10 months ago (2016-02-16 17:49:02 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704573002/20001
4 years, 10 months ago (2016-02-16 18:58:30 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:03:07 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/546d66544bcfac4bc9e77626ba549c4b3a79a654

Powered by Google App Engine
This is Rietveld 408576698