Add a GN assert that output dir doesn't have a platform name

Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
Committed: https://crrev.com/eeec8f2e249892e3f98a75b67cfadcb196ccbae1
Cr-Commit-Position: refs/heads/master@{#375664}

[agrieve, 2016-02-16 18:56:23]

Description was changed from

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
==========

to

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
==========

[agrieve, 2016-02-16 18:56:23]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2016-02-16 18:57:47]

On 2016/02/16 18:56:23, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:brettw@chromium.org

🍆

[brettw, 2016-02-16 19:19:58]

https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:35: set_sources_assignment_filter([
This is a clever idea!

I *think* the default sources assignment filter will apply without you doing
this. Does this test work if you just delete the set_... call? I would expect
that test will validate the current filter on the current platform without the
possibility of any skew in what the filter is and what you list out here.

[agrieve, 2016-02-16 20:04:20]

https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn
File build/config/BUILD.gn (right):

https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn#n...
build/config/BUILD.gn:35: set_sources_assignment_filter([
On 2016/02/16 19:19:58, brettw wrote:
> This is a clever idea!
> 
> I *think* the default sources assignment filter will apply without you doing
> this. Does this test work if you just delete the set_... call? I would expect
> that test will validate the current filter on the current platform without the
> possibility of any skew in what the filter is and what you list out here.

I had thought the same, but then figured it wouldn't catch the case of the
current platform being used. Just tried it however, and it worked just fine
(triggered the assert for is_android & "android").

Maybe this is the case due to a dep on a target($host_toolchain), which would
then have a linux filter?

Either way, it works, so i've made the change. :)

[brettw, 2016-02-16 20:11:05]

On 2016/02/16 20:04:20, agrieve wrote:
> https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn
> File build/config/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1704563003/diff/20001/build/config/BUILD.gn#n...
> build/config/BUILD.gn:35: set_sources_assignment_filter([
> On 2016/02/16 19:19:58, brettw wrote:
> > This is a clever idea!
> > 
> > I *think* the default sources assignment filter will apply without you doing
> > this. Does this test work if you just delete the set_... call? I would
expect
> > that test will validate the current filter on the current platform without
the
> > possibility of any skew in what the filter is and what you list out here.
> 
> I had thought the same, but then figured it wouldn't catch the case of the
> current platform being used. Just tried it however, and it worked just fine
> (triggered the assert for is_android & "android").
> 
> Maybe this is the case due to a dep on a target($host_toolchain), which would
> then have a linux filter?

It won't catch the case of the current platform being used, but then it won't
actually be a problem because nothing will be filtered out. An Android build
will have cross compiles so different toolchains will have different platform
definitions, so using an "android" dir will mess up the host toolchain build.

LGTM

[Dirk Pranke, 2016-02-16 20:15:03]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-02-16 20:15:03]

agreed, clever!

[agrieve, 2016-02-16 20:37:41]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-02-16 20:39:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1704563003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1704563003/40001

[commit-bot: I haz the power, 2016-02-16 21:17:29]

Description was changed from

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
==========

to

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
==========

[commit-bot: I haz the power, 2016-02-16 21:17:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-16 22:54:58]

Description was changed from

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283
==========

to

==========
Add a GN assert that output dir doesn't have a platform name

set_sources_assignment_filter() causes targets to have the wrong source
list when this happens.

BUG=548283

Committed: https://crrev.com/eeec8f2e249892e3f98a75b67cfadcb196ccbae1
Cr-Commit-Position: refs/heads/master@{#375664}
==========

[commit-bot: I haz the power, 2016-02-16 22:54:59]

Patchset 3 (id:??) landed as
https://crrev.com/eeec8f2e249892e3f98a75b67cfadcb196ccbae1
Cr-Commit-Position: refs/heads/master@{#375664}