Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1704553002: Implementing comma operator for asm->wasm. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Implementing comma operator for asm->wasm. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=mjsunit/asm-wasm R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/f0d7c7a83b7f4c8b6cc4ef1197f7503ae81a684e Cr-Commit-Position: refs/heads/master@{#34044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm.js View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704553002/1
4 years, 10 months ago (2016-02-16 16:37:52 UTC) #2
bradn
4 years, 10 months ago (2016-02-16 16:37:56 UTC) #3
titzer
On 2016/02/16 16:37:56, bradn wrote: lgtm
4 years, 10 months ago (2016-02-16 16:52:27 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 17:05:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704553002/1
4 years, 10 months ago (2016-02-16 18:32:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 18:34:11 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 18:34:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d7c7a83b7f4c8b6cc4ef1197f7503ae81a684e
Cr-Commit-Position: refs/heads/master@{#34044}

Powered by Google App Engine
This is Rietveld 408576698