Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 17045010: Revert 207875 "Native Android accessibility." (Closed)

Created:
7 years, 6 months ago by dmichael (off chromium)
Modified:
7 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 207875 "Native Android accessibility." Broke Android Tests: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests&number=5462 Some output: W 102s Main Failed obtaining tests from 014E378305008009 with exception: End Of File (EOF) in read_nonblocking(). Exception style platform. <pexpect.spawn object at 0x28d5510> version: 2.3 ($Revision: 399 $) command: /b/build_internal/scripts/slave/android/adb args: ['/b/build_internal/scripts/slave/android/adb', '-s', '014E378305008009', 'shell', 'cat', '/data/data/org.chromium.native_test/files/test.fifo'] searcher: searcher_re: 0: re.compile("<<ScopedMainEntryLogger") buffer (last 100 chars): before (last 100 chars): t/browser/accessibility/BrowserAccessibilityManager > Native Android accessibility. > > This is the final changelist that completes the initial implementation. > When accessibility is on and script injection is turned off or > unavailable, constructs a BrowserAccessibilityManager for the > ContentViewCore that provides a native accessibility implementation. > > BUG=242953 > R=benm@chromium.org, bulach@chromium.org, dtrainor@chromium.org > > Review URL: https://codereview.chromium.org/15741009 TBR=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+395 lines, -1026 lines) Patch
M trunk/src/android_webview/java/src/org/chromium/android_webview/AwContents.java View 3 chunks +0 lines, -15 lines 0 comments Download
M trunk/src/content/browser/accessibility/accessibility_tree_formatter_android.cc View 1 chunk +34 lines, -16 lines 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility_android.h View 2 chunks +55 lines, -30 lines 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility_android.cc View 11 chunks +256 lines, -128 lines 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility_manager_android.h View 1 chunk +3 lines, -10 lines 0 comments Download
M trunk/src/content/browser/accessibility/browser_accessibility_manager_android.cc View 7 chunks +15 lines, -195 lines 0 comments Download
M trunk/src/content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/android/content_view_core_impl.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M trunk/src/content/content_jni.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentView.java View 3 chunks +0 lines, -19 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 23 chunks +10 lines, -162 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 2 chunks +21 lines, -12 lines 0 comments Download
D trunk/src/content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 1 chunk +0 lines, -419 lines 0 comments Download
M trunk/src/content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmichael (off chromium)
7 years, 6 months ago (2013-06-21 19:00:35 UTC) #1
dmichael (off chromium)
7 years, 6 months ago (2013-06-21 19:00:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r207891.

Powered by Google App Engine
This is Rietveld 408576698