third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp - Issue 1704493002: Use Image::updateConcreteSize()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp

Issue 1704493002: Use Image::updateConcreteSize() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@add-image-updateconcretesize

Patch Set: Move test here from dependency CL. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutListMarker.cpp ('k') | third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp

diff --git a/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp b/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp

index b550ab161bc6762a2aff0696dc132c8cc3cc5e50..87136d48b360e8c66308165534331c8efb9ffa99 100644

--- a/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp

+++ b/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp

@@ -121,8 +121,12 @@ static bool isValidRasterShapeRect(const LayoutRect& rect)

PassOwnPtr<Shape> ShapeOutsideInfo::createShapeForImage(StyleImage* styleImage, float shapeImageThreshold, WritingMode writingMode, float margin) const

{

- const LayoutSize& imageSize = m_layoutBox.calculateImageIntrinsicDimensions(styleImage, m_referenceBoxLogicalSize, LayoutImage::ScaleByEffectiveZoom);

+ float effectiveZoom = m_layoutBox.style()->effectiveZoom();

+ LayoutSize defaultObjectSize(m_referenceBoxLogicalSize);

+ defaultObjectSize.scale(1 / effectiveZoom);

+ styleImage->updateConcreteObjectSize(defaultObjectSize);

+ const LayoutSize& imageSize = styleImage->imageSize(&m_layoutBox, effectiveZoom);

const LayoutRect& marginRect = getShapeImageMarginRect(m_layoutBox, m_referenceBoxLogicalSize);

const LayoutRect& imageRect = (m_layoutBox.isLayoutImage())

? toLayoutImage(m_layoutBox).replacedContentRect()

@@ -134,7 +138,7 @@ PassOwnPtr<Shape> ShapeOutsideInfo::createShapeForImage(StyleImage* styleImage,

}

ASSERT(!styleImage->isPendingImage());

- RefPtr<Image> image = styleImage->image(const_cast<LayoutBox*>(&m_layoutBox), flooredIntSize(imageSize), m_layoutBox.style()->effectiveZoom());

+ RefPtr<Image> image = styleImage->image(const_cast<LayoutBox*>(&m_layoutBox), flooredIntSize(imageSize), effectiveZoom);

return Shape::createRasterShape(image.get(), shapeImageThreshold, imageRect, marginRect, writingMode, margin);

}