Chromium Code Reviews

Issue 1704493002: Use Image::updateConcreteSize() (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@add-image-updateconcretesize
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Image::updateConcreteSize() Port call-sites using LayoutBoxModelObject::calculateImageIntrinsicDimensions over to updateConcreteSize() instead. BUG=581357

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Move contain constraint from earlier patch to here #

Patch Set 4 : Move test here from dependency CL. #

Unified diffs Side-by-side diffs Stats (+196 lines, -138 lines)
A third_party/WebKit/LayoutTests/svg/as-list-image/resources/green15x15.png View Binary file 0 comments
M third_party/WebKit/LayoutTests/svg/as-list-image/svg-list-image-intrinsic-size-zoom.html View 1 chunk +22 lines, -17 lines 0 comments
A third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing.html View 1 2 3 1 chunk +66 lines, -0 lines 0 comments
A third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html View 1 2 3 1 chunk +28 lines, -0 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +0 lines, -3 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 2 3 1 chunk +0 lines, -87 lines 0 comments
M third_party/WebKit/Source/core/layout/LayoutListMarker.cpp View 1 2 chunks +9 lines, -7 lines 0 comments
M third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 2 3 2 chunks +6 lines, -2 lines 0 comments
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 2 3 1 chunk +5 lines, -1 line 0 comments
M third_party/WebKit/Source/core/paint/NinePieceImagePainter.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 1 2 3 1 chunk +20 lines, -14 lines 0 comments
M third_party/WebKit/Source/core/style/StyleImage.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 2 3 1 chunk +19 lines, -5 lines 0 comments

Depends on Patchset:

Issue 1694263003 Patch 80001

Messages

Total messages: 1 (1 generated)
davve
4 years, 9 months ago (2016-03-03 08:18:15 UTC) #1 
Description was changed from

==========
Use Image::updateConcreteSize()

Port call-sites using
LayoutBoxModelObject::calculateImageIntrinsicDimensions over to
updateConcreteSize() instead.

BUG=581357
==========

to

==========
Use Image::updateConcreteSize()

Port call-sites using
LayoutBoxModelObject::calculateImageIntrinsicDimensions over to
updateConcreteSize() instead.

BUG=581357
==========

Powered by Google App Engine