Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: src/accessors.cc

Issue 1704373002: Fix GCMole issue. Iternalize name before dereferencing the accessor-info. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index 8d78b8fc26b77362e21b6301e023facecfee53e4..766509e2a5a40831d30097fef01882d1bfb1e3c8 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -32,7 +32,8 @@ Handle<AccessorInfo> Accessors::MakeAccessor(
info->set_all_can_read(false);
info->set_all_can_write(false);
info->set_is_special_data_property(true);
- info->set_name(*factory->InternalizeName(name));
+ name = factory->InternalizeName(name);
+ info->set_name(*name);
Handle<Object> get = v8::FromCData(isolate, getter);
if (setter == nullptr) setter = &ReconfigureToDataProperty;
Handle<Object> set = v8::FromCData(isolate, setter);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698