Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704373002: Fix GCMole issue. Iternalize name before dereferencing the accessor-info. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GCMole issue. Iternalize name before dereferencing the accessor-info. BUG= R=jkummerow@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/5363486d8ef332fcbbe1e01f5dc9a8854f6acdfb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/accessors.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-18 14:57:01 UTC) #2
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-18 15:00:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704373002/1
4 years, 10 months ago (2016-02-18 15:00:42 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5363486d8ef332fcbbe1e01f5dc9a8854f6acdfb Cr-Commit-Position: refs/heads/master@{#34120}
4 years, 10 months ago (2016-02-18 15:01:24 UTC) #7
Toon Verwaest
4 years, 10 months ago (2016-02-18 15:01:29 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5363486d8ef332fcbbe1e01f5dc9a8854f6acdfb (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698