Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1704363004: Track whether the Object.assign source is stable with a bool rather than map-check on each iteratio… (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Track whether the Object.assign source is stable with a bool rather than map-check on each iteration. BUG= Committed: https://crrev.com/0fbe943e312a36c411301268633a6ddb35a5daff Cr-Commit-Position: refs/heads/master@{#34153}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M src/builtins.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-19 12:44:09 UTC) #2
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-19 13:28:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704363004/1
4 years, 10 months ago (2016-02-19 13:32:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 13:53:06 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 13:53:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbe943e312a36c411301268633a6ddb35a5daff
Cr-Commit-Position: refs/heads/master@{#34153}

Powered by Google App Engine
This is Rietveld 408576698