src/compiler/access-info.cc - Issue 1704353002: [runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/access-info.cc

Issue 1704353002: [runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/access-info.cc

diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc

index 56a27d70eb07695cb98d2c011c3f38840c0ee27a..8d9cdb10a7a1d733e62c6ce1b273fc0d6993b669 100644

--- a/src/compiler/access-info.cc

+++ b/src/compiler/access-info.cc

@@ -231,6 +231,7 @@ bool AccessInfoFactory::ComputePropertyAccessInfo(

// Compute the receiver type.

Handle<Map> receiver_map = map;

+ name = isolate()->factory()->InternalizeName(name);

Michael Starzinger 2016/02/18 12:49:55 suggestion/nit: Should we add a short comment that

// We support fast inline cases for certain JSObject getters.

if (access_mode == AccessMode::kLoad &&

« no previous file with comments | « src/accessors.cc ('k') | src/crankshaft/hydrogen.h » ('j') | no next file with comments »