[runtime] Force internalize names used before lookup in in DescriptorArray and TransitionArray

src/lookup.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_LOOKUP_H_
 #define V8_LOOKUP_H_
 
 #include "src/factory.h"
 #include "src/isolate.h"
 #include "src/objects.h"
@@ skipping 33 matching lines @@
     BEFORE_PROPERTY = INTERCEPTOR
   };
 
   LookupIterator(Handle<Object> receiver, Handle<Name> name,
                  Configuration configuration = DEFAULT)
       : configuration_(ComputeConfiguration(configuration, name)),
         state_(NOT_FOUND),
         interceptor_state_(InterceptorState::kUninitialized),
         property_details_(PropertyDetails::Empty()),
         isolate_(name->GetIsolate()),
-        name_(Name::Flatten(name)),
+        name_(isolate_->factory()->InternalizeName(name)),
         // kMaxUInt32 isn't a valid index.
         index_(kMaxUInt32),
         receiver_(receiver),
         holder_(GetRoot(isolate_, receiver)),
         initial_holder_(holder_),
         number_(DescriptorArray::kNotFound) {
 #ifdef DEBUG
     uint32_t index;  // Assert that the name is not an array index.
     DCHECK(!name->AsArrayIndex(&index));
 #endif  // DEBUG
     Next();
   }
 
   LookupIterator(Handle<Object> receiver, Handle<Name> name,
                  Handle<JSReceiver> holder,
                  Configuration configuration = DEFAULT)
       : configuration_(ComputeConfiguration(configuration, name)),
         state_(NOT_FOUND),
         interceptor_state_(InterceptorState::kUninitialized),
         property_details_(PropertyDetails::Empty()),
         isolate_(name->GetIsolate()),
-        name_(Name::Flatten(name)),
+        name_(isolate_->factory()->InternalizeName(name)),
         // kMaxUInt32 isn't a valid index.
         index_(kMaxUInt32),
         receiver_(receiver),
         holder_(holder),
         initial_holder_(holder_),
         number_(DescriptorArray::kNotFound) {
 #ifdef DEBUG
     uint32_t index;  // Assert that the name is not an array index.
     DCHECK(!name->AsArrayIndex(&index));
 #endif  // DEBUG
@@ skipping 33 matching lines @@
         initial_holder_(holder_),
         number_(DescriptorArray::kNotFound) {
     // kMaxUInt32 isn't a valid index.
     DCHECK_NE(kMaxUInt32, index_);
     Next();
   }
 
   static LookupIterator PropertyOrElement(
       Isolate* isolate, Handle<Object> receiver, Handle<Name> name,
       Configuration configuration = DEFAULT) {
-    name = Name::Flatten(name);
+    name = isolate->factory()->InternalizeName(name);
     uint32_t index;
     LookupIterator it =
         name->AsArrayIndex(&index)
             ? LookupIterator(isolate, receiver, index, configuration)
             : LookupIterator(receiver, name, configuration);
     it.name_ = name;
     return it;
   }
 
   static LookupIterator PropertyOrElement(
       Isolate* isolate, Handle<Object> receiver, Handle<Name> name,
       Handle<JSReceiver> holder, Configuration configuration = DEFAULT) {
-    name = Name::Flatten(name);
+    name = isolate->factory()->InternalizeName(name);
     uint32_t index;
     LookupIterator it =
         name->AsArrayIndex(&index)
             ? LookupIterator(isolate, receiver, index, holder, configuration)
             : LookupIterator(receiver, name, holder, configuration);
     it.name_ = name;
     return it;
   }
 
   static LookupIterator PropertyOrElement(
@@ skipping 95 matching lines @@
   int GetAccessorIndex() const;
   int GetConstantIndex() const;
   Handle<PropertyCell> GetPropertyCell() const;
   Handle<Object> GetAccessors() const;
   inline Handle<InterceptorInfo> GetInterceptor() const {
     DCHECK_EQ(INTERCEPTOR, state_);
     return handle(GetInterceptor(JSObject::cast(*holder_)), isolate_);
   }
   Handle<Object> GetDataValue() const;
   void WriteDataValue(Handle<Object> value);
-  void InternalizeName();
 
  private:
   enum class InterceptorState {
     kUninitialized,
     kSkipNonMasking,
     kProcessNonMasking
   };
 
   Handle<Map> GetReceiverMap() const;
 
@@ skipping 66 matching lines @@
   Handle<JSReceiver> holder_;
   const Handle<JSReceiver> initial_holder_;
   uint32_t number_;
 };
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_LOOKUP_H_