Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: tools/bots/bot_utils.py

Issue 1704323002: Archive unstripped dart binaries on the sdk builders (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/bots/dart_sdk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/bot_utils.py
diff --git a/tools/bots/bot_utils.py b/tools/bots/bot_utils.py
index 1feaf2c136af693a83f85ff4ddff2457d3e39ed9..1e2ce69fb72876e695b86d001566afce5f680860 100644
--- a/tools/bots/bot_utils.py
+++ b/tools/bots/bot_utils.py
@@ -115,6 +115,12 @@ class GCSNamer(object):
return '/'.join([self.sdk_directory(revision),
self.sdk_zipfilename(system, arch, mode)])
+ def unstripped_filepath(self, revision, system, arch):
+ return '/'.join([self._variant_directory('unstripped', revision),
+ system,
+ arch,
+ self.unstripped_filename(system)])
+
def dartium_variant_zipfilepath(self, revision, name, system, arch, mode):
return '/'.join([self.dartium_directory(revision),
self.dartium_variant_zipfilename(name, system, arch, mode)])
@@ -186,6 +192,9 @@ class GCSNamer(object):
return 'dartsdk-%s-%s-%s.zip' % (
SYSTEM_RENAMES[system], ARCH_RENAMES[arch], mode)
+ def unstripped_filename(self, system):
+ return 'dart.exe' if system.startswith('win') else 'dart'
+
def dartium_variant_zipfilename(self, name, system, arch, mode):
assert name in ['chromedriver', 'dartium', 'content_shell']
assert mode in Mode.ALL_MODES
« no previous file with comments | « no previous file | tools/bots/dart_sdk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698