Fix the WebRTC color bug.

media/base/simd/convert_rgb_to_yuv_c.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/simd/convert_rgb_to_yuv.h"
 
 namespace media {
 
 static int clip_byte(int x) {
   if (x > 255)
@@ skipping 10 matching lines @@
                          uint8* vplane,
                          int width,
                          int height,
                          int rgbstride,
                          int ystride,
                          int uvstride) {
   for (int i = 0; i < height; ++i) {
     for (int j = 0; j < width; ++j) {
       // Since the input pixel format is RGB32, there are 4 bytes per pixel.
       const uint8* pixel = rgbframe + 4 * j;
+#if defined(OS_ANDROID)
+      yplane[j] = clip_byte(((pixel[0] * 66 + pixel[1] * 129 +

[scherkus (not reviewing), 2013/06/19 19:49:50]

this is mostly duplicated -- can you instead do something like the following?

#if defined(OS_ANDROID)
const int r = 2;
const int g = 1;
const int b = 0;
#else
const int r = 0;
const int g = 1;
const int b = 2;
#endif

... then referring to pixel with pixel[r], pixel[g], etc...

[hkuang1, 2013/06/19 23:21:11]

Done.

+                             pixel[2] * 25 + 128) >> 8) + 16);
+      if (i % 2 == 0 && j % 2 == 0) {
+        uplane[j / 2] = clip_byte(((pixel[0] * -38 + pixel[1] * -74 +
+                                   pixel[2] * 112 + 128) >> 8) + 128);
+        vplane[j / 2] = clip_byte(((pixel[0] * 112 + pixel[1] * -94 +
+                                    pixel[2] * -18 + 128) >> 8) + 128);
+      }
+#else
       yplane[j] = clip_byte(((pixel[2] * 66 + pixel[1] * 129 +
                              pixel[0] * 25 + 128) >> 8) + 16);
       if (i % 2 == 0 && j % 2 == 0) {
         uplane[j / 2] = clip_byte(((pixel[2] * -38 + pixel[1] * -74 +
                                    pixel[0] * 112 + 128) >> 8) + 128);
         vplane[j / 2] = clip_byte(((pixel[2] * 112 + pixel[1] * -94 +
                                     pixel[0] * -18 + 128) >> 8) + 128);
       }
+#endif
     }
-
     rgbframe += rgbstride;
     yplane += ystride;
     if (i % 2 == 0) {
       uplane += uvstride;
       vplane += uvstride;
     }
   }
 }
 
 void ConvertRGB24ToYUV_C(const uint8* rgbframe,
@@ skipping 22 matching lines @@
     rgbframe += rgbstride;
     yplane += ystride;
     if (i % 2 == 0) {
       uplane += uvstride;
       vplane += uvstride;
     }
   }
 }
 
 }  // namespace media