Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: chrome/browser/renderer_host/pepper/pepper_talk_host.h

Issue 17043006: Implement supporting UI HRD-on-ChromeOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use proper error constants in Start/StopRemoting. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/pepper/pepper_talk_host.h
diff --git a/chrome/browser/renderer_host/pepper/pepper_talk_host.h b/chrome/browser/renderer_host/pepper/pepper_talk_host.h
index 3b754fd05b8ae049af0e9236975b717edc2952a6..2aaaf1781b2c9e622bf8ec9a0439008517091be7 100644
--- a/chrome/browser/renderer_host/pepper/pepper_talk_host.h
+++ b/chrome/browser/renderer_host/pepper/pepper_talk_host.h
@@ -29,25 +29,24 @@ class PepperTalkHost : public ppapi::host::ResourceHost {
PP_Resource resource);
virtual ~PepperTalkHost();
+ private:
// ResourceHost override.
virtual int32_t OnResourceMessageReceived(
const IPC::Message& msg,
ppapi::host::HostMessageContext* context) OVERRIDE;
- // Sends the reply.
- void GotTalkPermission(ppapi::host::ReplyMessageContext reply);
-
- private:
- int32_t OnRequestPermission(
- ppapi::host::HostMessageContext* context,
- PP_TalkPermission permission);
- int32_t OnStartRemoting(
- ppapi::host::HostMessageContext* context);
- int32_t OnStopRemoting(
- ppapi::host::HostMessageContext* context);
+ int32_t OnRequestPermission(ppapi::host::HostMessageContext* context,
raymes 2013/06/18 00:30:51 nit: usually we have the message handlers grouped
dcaiafa 2013/06/18 16:36:40 Done.
+ PP_TalkPermission permission);
+ void OnRequestPermissionCompleted(ppapi::host::ReplyMessageContext reply);
+ int32_t OnStartRemoting(ppapi::host::HostMessageContext* context);
+ void OnStartRemotingCompleted(ppapi::host::ReplyMessageContext reply);
+ int32_t OnStopRemoting(ppapi::host::HostMessageContext* context);
+ void OnStopRemotingCompleted(ppapi::host::ReplyMessageContext reply);
+ void OnRemotingStopEvent();
base::WeakPtrFactory<PepperTalkHost> weak_factory_;
content::BrowserPpapiHost* browser_ppapi_host_;
+ bool remoting_started_;
DISALLOW_COPY_AND_ASSIGN(PepperTalkHost);
};

Powered by Google App Engine
This is Rietveld 408576698