Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1704263002: Set the linter target (Closed)

Created:
4 years, 10 months ago by sgurun-gerrit only
Modified:
4 years, 10 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the linter target for awwebcontentsdelegateadapter class Set the target API for the class to 21 (lollipop) which is what is supported by updatable webview. This prevents us individually suppress lint messages. BUG= Committed: https://crrev.com/b3e2647ddfa063cbb40dabba45ae7aa1e89c647e Cr-Commit-Position: refs/heads/master@{#376057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sgurun-gerrit only
On 2016/02/18 00:59:57, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:mnaganov@chromium.org Mikhail, ptal. thanks
4 years, 10 months ago (2016-02-18 01:06:06 UTC) #3
mnaganov (inactive)
lgtm
4 years, 10 months ago (2016-02-18 01:11:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704263002/1
4 years, 10 months ago (2016-02-18 01:13:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 01:39:30 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 01:40:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3e2647ddfa063cbb40dabba45ae7aa1e89c647e
Cr-Commit-Position: refs/heads/master@{#376057}

Powered by Google App Engine
This is Rietveld 408576698