Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1704253002: Reland: Add Scoped Context Info (Isolate) to V8 Traces (Closed)

Created:
4 years, 10 months ago by fmeawad
Modified:
4 years, 9 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: Add Scoped Context Info (Isolate) to V8 Traces This patch adds the newly added support for contexts in V8 Tracing, as well as use it to mark all the entry points for a V8 Isolate. Update for reland: The current tracing interface needs to be updated (AddTraceEvent), but the embedders need to migrate to the new version before removing the old version. (Reland of: https://codereview.chromium.org/1686233002) The revert happened because the 2 signatures of the old and new AddTraceEvent where different so it threw an overload-virtual error on cross arm debug. This issue is temporary, and to solve it, I added an implementation of the old and new everywhere until the embedder implements the new. BUG=v8:4565 LOG=N R=jochen@chromium.org Committed: https://crrev.com/567e58390d86c54ebd527d1b95500c415f3caeb5 Cr-Commit-Position: refs/heads/master@{#34332}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -75 lines) Patch
M include/v8-platform.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/api.cc View 1 8 chunks +8 lines, -0 lines 0 comments Download
M src/d8.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/libplatform/default-platform.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M src/tracing/trace-event.h View 11 chunks +139 lines, -73 lines 0 comments Download
M test/cctest/heap/test-incremental-marking.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-trace-event.cc View 3 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fmeawad
Hi Jochen, I added some dummy bodies that I will remove once I update the ...
4 years, 9 months ago (2016-02-25 23:45:27 UTC) #1
fmeawad
PTAL
4 years, 9 months ago (2016-02-25 23:45:35 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-02-26 12:13:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704253002/20001
4 years, 9 months ago (2016-02-26 12:27:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/2001) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-02-26 12:56:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704253002/20001
4 years, 9 months ago (2016-02-26 17:03:51 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-26 17:24:20 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-02-26 17:25:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/567e58390d86c54ebd527d1b95500c415f3caeb5
Cr-Commit-Position: refs/heads/master@{#34332}

Powered by Google App Engine
This is Rietveld 408576698