Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1704243003: ozone/platform/wayland: Implement SurfaceOzoneEGL (Closed)

Created:
4 years, 10 months ago by Michael Forney
Modified:
4 years, 8 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone/platform/wayland: Implement SurfaceOzoneEGL BUG=578890 Committed: https://crrev.com/bc96672e1982f3a86e4058a2f3f8609b9bc592c8 Cr-Commit-Position: refs/heads/master@{#386765}

Patch Set 1 #

Patch Set 2 : Add missing wayland_egl_surface.{cc,h} #

Patch Set 3 : Fix gyp build #

Patch Set 4 : Drop unrelated surface/widget accessor renames #

Patch Set 5 : Rebase, drop dependency on pointer patchset #

Total comments: 6

Patch Set 6 : Remove unnecessary DCHECKs #

Patch Set 7 : Rebase, fix scoped_ptr NULL check, make use_wayland_egl default to true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -6 lines) Patch
M build/linux/system.gyp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/BUILD.gn View 1 2 3 4 5 6 2 chunks +21 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland.gypi View 1 2 3 4 5 6 2 chunks +15 lines, -0 lines 0 comments Download
A ui/ozone/platform/wayland/wayland_egl_surface.h View 1 1 chunk +49 lines, -0 lines 0 comments Download
A ui/ozone/platform/wayland/wayland_egl_surface.cc View 1 2 3 4 5 6 1 chunk +79 lines, -0 lines 0 comments Download
M ui/ozone/platform/wayland/wayland_surface_factory.cc View 1 2 3 4 5 6 3 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
Michael Forney
I ran into a few issues with this. `mojo_runner mojo:mash_shell` does not start at all ...
4 years, 10 months ago (2016-02-24 07:36:01 UTC) #2
dnicoara
On 2016/02/24 07:36:01, Michael Forney wrote: > I ran into a few issues with this. ...
4 years, 10 months ago (2016-02-24 15:14:29 UTC) #3
spang
https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn File ui/ozone/platform/wayland/BUILD.gn (right): https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn#newcode10 ui/ozone/platform/wayland/BUILD.gn:10: use_wayland_egl = false Does it need to be configurable ...
4 years, 10 months ago (2016-02-24 16:12:11 UTC) #4
Michael Forney
https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn File ui/ozone/platform/wayland/BUILD.gn (right): https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn#newcode10 ui/ozone/platform/wayland/BUILD.gn:10: use_wayland_egl = false On 2016/02/24 16:12:11, spang wrote: > ...
4 years, 10 months ago (2016-02-24 22:46:41 UTC) #5
spang
https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn File ui/ozone/platform/wayland/BUILD.gn (right): https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn#newcode10 ui/ozone/platform/wayland/BUILD.gn:10: use_wayland_egl = false On 2016/02/24 22:46:41, Michael Forney wrote: ...
4 years, 10 months ago (2016-02-25 00:37:31 UTC) #6
Michael Forney
https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn File ui/ozone/platform/wayland/BUILD.gn (right): https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn#newcode10 ui/ozone/platform/wayland/BUILD.gn:10: use_wayland_egl = false On 2016/02/25 00:37:30, spang wrote: > ...
4 years, 8 months ago (2016-04-01 18:19:33 UTC) #7
spang
On 2016/04/01 18:19:33, Michael Forney wrote: > https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn > File ui/ozone/platform/wayland/BUILD.gn (right): > > https://codereview.chromium.org/1704243003/diff/80001/ui/ozone/platform/wayland/BUILD.gn#newcode10 ...
4 years, 8 months ago (2016-04-01 18:58:28 UTC) #8
spang
On 2016/04/01 18:58:28, spang wrote: > On 2016/04/01 18:19:33, Michael Forney wrote: > > > ...
4 years, 8 months ago (2016-04-01 19:05:02 UTC) #9
Michael Forney
Adding mmoss for build/linux/OWNERS.
4 years, 8 months ago (2016-04-12 01:00:46 UTC) #11
Michael Moss
lgtm
4 years, 8 months ago (2016-04-12 16:47:27 UTC) #12
rjkroege
lgtm if you're waiting.
4 years, 8 months ago (2016-04-12 17:42:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704243003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704243003/120001
4 years, 8 months ago (2016-04-12 17:46:14 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-12 19:38:46 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-12 19:40:58 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/bc96672e1982f3a86e4058a2f3f8609b9bc592c8
Cr-Commit-Position: refs/heads/master@{#386765}

Powered by Google App Engine
This is Rietveld 408576698