Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704243002: Support processing microdumps for x86 architecture. (Closed)

Created:
4 years, 10 months ago by mmandlis
Modified:
4 years, 10 months ago
CC:
google-breakpad-dev_googlegroups.com, mnaganov (inactive)
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add the testdata file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -6 lines) Patch
M src/google_breakpad/processor/microdump.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/processor/microdump.cc View 3 chunks +16 lines, -0 lines 0 comments Download
M src/processor/microdump_processor_unittest.cc View 6 chunks +25 lines, -6 lines 0 comments Download
A src/processor/testdata/microdump-x86.dmp View 1 1 chunk +174 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mmandlis
4 years, 10 months ago (2016-02-18 00:56:33 UTC) #3
Primiano Tucci (use gerrit)
dejavu LGTM :)
4 years, 10 months ago (2016-02-18 12:11:25 UTC) #4
mmandlis
Committed patchset #2 (id:20001) manually as 344b79d61a24683989dbf71744865b71d481cf14 (presubmit successful).
4 years, 10 months ago (2016-02-18 14:14:01 UTC) #6
stackndatmayo
How do i download the patch??
4 years, 10 months ago (2016-02-20 05:02:36 UTC) #8
Primiano Tucci (use gerrit)
4 years, 10 months ago (2016-02-22 04:47:19 UTC) #9
Message was sent while issue was closed. 
On 2016/02/20 05:02:36, stackndatmayo wrote:
> How do i download the patch??

There is a download link on the right which says "Download" 
This change is live upstream btw.

Powered by Google App Engine
This is Rietveld 408576698