Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1704223003: third_party/binutils: Add --enable-deterministic-archives (Closed)

Created:
4 years, 10 months ago by mithro
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/binutils: Add --enable-deterministic-archives This flag makes the output of ar built from binutils to be deterministic by default. (Also small formatting change to the ./configure arguments.) BUG=579369 Committed: https://crrev.com/ba77f6374bdd468e7a9542c626c8e10c436323a0 Cr-Commit-Position: refs/heads/master@{#378721}

Patch Set 1 #

Patch Set 2 : Small fixes to build-one and binutil sha1 files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M third_party/binutils/Linux_ia32/binutils.tar.bz2.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/Linux_x64/binutils.tar.bz2.sha1 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/binutils/build-one.sh View 1 3 chunks +25 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
mithro
Hi everyone, Very small change to binutils build scripts to enable deterministic archives. Will rebuild ...
4 years, 10 months ago (2016-02-18 07:09:17 UTC) #2
Nico
lgtm, thanks :-) Please make sure the new binutils is uploaded to goma before you ...
4 years, 10 months ago (2016-02-18 14:42:20 UTC) #3
Nico
(if you don't know how to do this, email goma@google.com and say "i built a ...
4 years, 10 months ago (2016-02-18 14:42:55 UTC) #4
krasin1
Also, this change does not include new hashes for binutils, which means that third_party/binutils/upload.sh was ...
4 years, 10 months ago (2016-02-18 17:58:39 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704223003/20001
4 years, 10 months ago (2016-02-26 08:58:33 UTC) #7
Yoshisato Yanagisawa
Let me confirm it usable with CQ dry run.
4 years, 10 months ago (2016-02-26 08:59:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-26 10:30:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704223003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704223003/20001
4 years, 9 months ago (2016-03-02 09:35:53 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 10:40:10 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 10:41:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba77f6374bdd468e7a9542c626c8e10c436323a0
Cr-Commit-Position: refs/heads/master@{#378721}

Powered by Google App Engine
This is Rietveld 408576698