Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1704213002: Revert of Fix LNK1210 when linking blink_core.dll in gn builds. (Closed)

Created:
4 years, 10 months ago by sky
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, Nico, scottmg
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix LNK1210 when linking blink_core.dll in gn builds. (patchset #2 id:20001 of https://codereview.chromium.org/1709783002/ ) Reason for revert: scottmg says we should revert the patch that caused the issue. Which means I have to revert this one first. So, doing that. Original issue's description: > Fix LNK1210 when linking blink_core.dll in gn builds. > > This matches the 'LinkIncremental': '1' for webcore_shared > in core.gyp ('1' means 'off' for LinkIncremental). > > Patch dictated by scottmg over a noisy channel; typing and > denoising by me. > > BUG=587530 > R=scottmg@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/432d2962b984956cfa90653d8d5a082f40703667 TBR=dpranke@chromium.org,scottmg@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=587530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sky
Created Revert of Fix LNK1210 when linking blink_core.dll in gn builds.
4 years, 10 months ago (2016-02-17 22:32:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704213002/1
4 years, 10 months ago (2016-02-17 22:34:51 UTC) #3
sky
4 years, 10 months ago (2016-02-17 22:40:16 UTC) #5
On 2016/02/17 22:34:51, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1704213002/1
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1704213002/1

We decided not to do the revert, so closing this out.

Powered by Google App Engine
This is Rietveld 408576698