DescriptionRevert of Fix LNK1210 when linking blink_core.dll in gn builds. (patchset #2 id:20001 of https://codereview.chromium.org/1709783002/ )
Reason for revert:
scottmg says we should revert the patch that caused the issue. Which means I have to revert this one first. So, doing that.
Original issue's description:
> Fix LNK1210 when linking blink_core.dll in gn builds.
>
> This matches the 'LinkIncremental': '1' for webcore_shared
> in core.gyp ('1' means 'off' for LinkIncremental).
>
> Patch dictated by scottmg over a noisy channel; typing and
> denoising by me.
>
> BUG=587530
> R=scottmg@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/432d2962b984956cfa90653d8d5a082f40703667
TBR=dpranke@chromium.org,scottmg@chromium.org,thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=587530
Patch Set 1 #
Messages
Total messages: 5 (2 generated)
|