Drag and drop: Paint issues with Find-in bar.

* Modified.

Update the position of the find-bar when its parent window is changed. (by FindBarWin::SetParent)

* Why?

When the tab that has the find-bar is detached from the browser and becomes a new window by drag-and-drop,
the parent window of the find-bar is changed.
In this case, find-bar becomes located in the wrong position. (a little upper than its right position)

So, when the parent of the find-bar is changed, update the position of the find-bar to have the right position.

* How to reproduce the bug

1. Execute chrome browser with maximized.
2. Make one more tab using '+' button.
3. Make find-bar with 'Ctrl + F'.
3. Drag and drop this tab to be the new window.

Then, the find-bar in the newly created window is placed in the wrong place.

* Environment

MS Windows XP Professional, Chromium 1.0.156.0 (Developer Build 7480)

* BUG=3245
(Issue 3245: Drag and drop: Paint issues with Find-in bar.
 http://crbug.com/3245)

[Peter Kasting, 2009-01-05 20:28:55]

Changed reviewers to appropriate people

[Finnur, 2009-01-06 18:18:22]

I can reproduce the problem you describe with and without this patch. Are you
sure you haven't left out any code/files in the patch?

Also, the problem you describe is not the same as the one described in the bug.
I'll update the bug with more comments and propose that we wait until Ben checks
in his changes to the Find box, because he's changing the ownership of the Find
window - which affects this probably.

[DeArto20, 2009-01-07 08:03:36]

I have noticed the differences between two problems as you indicated.

But about the above problem (find-bar in the wrong place), I tested a lot of
times with my patch but I couldn't reproduce the bug.

And there's no other files left out. 'find_bar_win.cc' is the only file to be
modified.

Please let me know how to reproduce the above bug. Regardless of the Ben's work,
I wanna check it.

Thanks.

[Finnur, 2009-01-07 15:58:03]

Oh, wait - are you saying that you can only reproduce the find bar painting
problem and not the location problem and that your patch fixes the painting
problem (and not the location problem as I thought)?

In that case, my testing was invalid because I've not been able to reproduce the
painting problem on my machine. Let me know if so and I will give a build with
your patch to Venkat to test - he can reproduce the painting problem on his
machine.

On 2009/01/07 08:03:36, DeArto20 wrote:
> I have noticed the differences between two problems as you indicated.
> 
> But about the above problem (find-bar in the wrong place), I tested a lot of
> times with my patch but I couldn't reproduce the bug.
> 
> And there's no other files left out. 'find_bar_win.cc' is the only file to be
> modified.
> 
> Please let me know how to reproduce the above bug. Regardless of the Ben's
work,
> I wanna check it.
> 
> Thanks.

[DeArto20, 2009-01-07 19:51:21]

I'm not saying about the painting problem but the location problem. Maybe my
prior description was not so clear. Sorry.

Let me explain one more time.

I can easily reproduce the location problem without my patch. But after my patch
is applied, I cannot reproduce it any more.

So, if you can reproduce the location problem with my patch applied, please let
me know the exact way to do it. I wanna see it.


On 2009/01/07 15:58:03, Finnur wrote:
> Oh, wait - are you saying that you can only reproduce the find bar painting
> problem and not the location problem and that your patch fixes the painting
> problem (and not the location problem as I thought)?
> 
> In that case, my testing was invalid because I've not been able to reproduce
the
> painting problem on my machine. Let me know if so and I will give a build with
> your patch to Venkat to test - he can reproduce the painting problem on his
> machine.
> 
> On 2009/01/07 08:03:36, DeArto20 wrote:
> > I have noticed the differences between two problems as you indicated.
> > 
> > But about the above problem (find-bar in the wrong place), I tested a lot of
> > times with my patch but I couldn't reproduce the bug.
> > 
> > And there's no other files left out. 'find_bar_win.cc' is the only file to
be
> > modified.
> > 
> > Please let me know how to reproduce the above bug. Regardless of the Ben's
> work,
> > I wanna check it.
> > 
> > Thanks.

[Finnur, 2009-01-07 19:53:12]

Yes, the location problem I can easily reproduce with and without your patch.

So, lets wait for Ben to check in his patch - maybe next week? - and then
revisit this.

On 2009/01/07 19:51:21, DeArto20 wrote:
> I'm not saying about the painting problem but the location problem. Maybe my
> prior description was not so clear. Sorry.
> 
> Let me explain one more time.
> 
> I can easily reproduce the location problem without my patch. But after my
patch
> is applied, I cannot reproduce it any more.
> 
> So, if you can reproduce the location problem with my patch applied, please
let
> me know the exact way to do it. I wanna see it.
> 
> 
> On 2009/01/07 15:58:03, Finnur wrote:
> > Oh, wait - are you saying that you can only reproduce the find bar painting
> > problem and not the location problem and that your patch fixes the painting
> > problem (and not the location problem as I thought)?
> > 
> > In that case, my testing was invalid because I've not been able to reproduce
> the
> > painting problem on my machine. Let me know if so and I will give a build
with
> > your patch to Venkat to test - he can reproduce the painting problem on his
> > machine.
> > 
> > On 2009/01/07 08:03:36, DeArto20 wrote:
> > > I have noticed the differences between two problems as you indicated.
> > > 
> > > But about the above problem (find-bar in the wrong place), I tested a lot
of
> > > times with my patch but I couldn't reproduce the bug.
> > > 
> > > And there's no other files left out. 'find_bar_win.cc' is the only file to
> be
> > > modified.
> > > 
> > > Please let me know how to reproduce the above bug. Regardless of the Ben's
> > work,
> > > I wanna check it.
> > > 
> > > Thanks.

[Finnur, 2009-01-12 20:55:30]

Ben said:

> Given the priority on stabilization right now it's unlikely
> that I'll be able to spend much time in the short term 
> finishing the find bar changes I have, so go ahead with 
> whatever approach works for the current code.

I still think we should wait and see if this is still an issue with your patch,
given that this patch doesn't seem to fix the issue with the current codebase.