Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 1704193002: Make build_command_buffer.py work on Mac and Windows (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make build_command_buffer.py work on Mac and Windows. Also specify GYP_GENERATORS and add flags to gclient sync to make it more likely to succeed. BUG=skia:4957 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704193002 Committed: https://skia.googlesource.com/skia/+/c969bfced3849a73f6c015367beed5b46142f333

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M tools/build_command_buffer.py View 1 2 3 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
bsalomon
4 years, 10 months ago (2016-02-17 22:20:39 UTC) #5
borenet
LGTM with nits https://codereview.chromium.org/1704193002/diff/20001/tools/build_command_buffer.py File tools/build_command_buffer.py (right): https://codereview.chromium.org/1704193002/diff/20001/tools/build_command_buffer.py#newcode139 tools/build_command_buffer.py:139: shared_lib_subdir) Nits: Can we call this ...
4 years, 10 months ago (2016-02-18 12:43:20 UTC) #6
bsalomon
https://codereview.chromium.org/1704193002/diff/20001/tools/build_command_buffer.py File tools/build_command_buffer.py (right): https://codereview.chromium.org/1704193002/diff/20001/tools/build_command_buffer.py#newcode139 tools/build_command_buffer.py:139: shared_lib_subdir) On 2016/02/18 12:43:20, borenet wrote: > Nits: Can ...
4 years, 10 months ago (2016-02-18 14:19:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704193002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704193002/40001
4 years, 10 months ago (2016-02-18 14:19:34 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 14:40:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c969bfced3849a73f6c015367beed5b46142f333

Powered by Google App Engine
This is Rietveld 408576698