Issue 1704173002: Use shared error for constructor's with return type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1704173002: Use shared error for constructor's with return type. (Closed)

Created:
4 years, 10 months ago by floitsch

Modified:
4 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Brian Wilkerson

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use shared error for constructor's with return type. Dart2js reports constructor's with return type, as long as the class is used. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3301bc7786a0a81b5a6971fc37e632931abdab30

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -8 lines)			Patch
M	pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/diagnostics/messages.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	pkg/dart_messages/lib/generated/shared_messages.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/dart_messages/lib/shared_messages.dart	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

floitsch

4 years, 10 months ago (2016-02-17 22:50:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3301bc7786a0a81b5a6971fc37e632931abdab30 (presubmit successful).