net/base/escape.cc - Issue 1704163003: FileURLToFilePath: Don't unescape '/' and '\\'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/escape.cc

Issue 1704163003: FileURLToFilePath: Don't unescape '/' and '\\'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/escape.cc

diff --git a/net/base/escape.cc b/net/base/escape.cc

index 15de5e1dbd37d1720eec25cab678654c95c98777..1a1b7357e17fb7cf3809e461f4d9924ed307af15 100644

--- a/net/base/escape.cc

+++ b/net/base/escape.cc

@@ -291,6 +291,8 @@ STR UnescapeURLWithAdjustmentsImpl(

// Allow any of the prohibited but non-control characters when

// we're doing "special" chars.

(first_byte > ' ' && (rules & UnescapeRule::URL_SPECIAL_CHARS)) ||

+ (first_byte > ' ' && first_byte != '/' && first_byte != '\\' &&

+ (rules & UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPERATORS)) ||

// Additionally allow non-display characters if requested.

(first_byte < ' ' &&

(rules & UnescapeRule::SPOOFING_AND_CONTROL_CHARS)))) {