net/base/filename_util.cc - Issue 1704163003: FileURLToFilePath: Don't unescape '/' and '\\'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/filename_util.cc

Issue 1704163003: FileURLToFilePath: Don't unescape '/' and '\\'. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Made comment less scary Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/filename_util.cc

diff --git a/net/base/filename_util.cc b/net/base/filename_util.cc

index 0969f7155215884875a69992130e37098ef1db07..153ce43d024882f3d48d62fb1c338930a7d50ee1 100644

--- a/net/base/filename_util.cc

+++ b/net/base/filename_util.cc

@@ -98,7 +98,8 @@ bool FileURLToFilePath(const GURL& url, base::FilePath* file_path) {

// GURL stores strings as percent-encoded 8-bit, this will undo if possible.

path = UnescapeURLComponent(

- path, UnescapeRule::SPACES | UnescapeRule::URL_SPECIAL_CHARS);

+ path, UnescapeRule::SPACES |

+ UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS);

#if defined(OS_WIN)

if (base::IsStringUTF8(path)) {

« no previous file with comments | « net/base/escape_unittest.cc ('k') | net/base/filename_util_unittest.cc » ('j') | no next file with comments »