Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1704143002: bin/sync-and-gyp: better error checking (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
Brian Osman
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

bin/sync-and-gyp: better error checking NOTRY=true Committed: https://skia.googlesource.com/skia/+/68af68a0efa50c72ff69003bb8e37268cba985fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M bin/sync-and-gyp View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
hal.canary
PTAL
4 years, 10 months ago (2016-02-17 20:57:36 UTC) #3
mtklein
I don't like the idea of having to make our internal tools user friendly.
4 years, 10 months ago (2016-02-17 21:04:33 UTC) #5
Brian Osman
lgtm
4 years, 10 months ago (2016-02-17 21:06:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1704143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1704143002/1
4 years, 10 months ago (2016-02-17 21:06:56 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:07:41 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/68af68a0efa50c72ff69003bb8e37268cba985fc

Powered by Google App Engine
This is Rietveld 408576698