TaskScheduler [6] SchedulerWorkerThread

base/task_scheduler/utils.cc

Index: base/task_scheduler/utils.cc
diff --git a/base/task_scheduler/utils.cc b/base/task_scheduler/utils.cc
new file mode 100644
index 0000000000000000000000000000000000000000..80f04d0b8a1dc73c304ebc75cfac074248fbc3c4
--- /dev/null
+++ b/base/task_scheduler/utils.cc
@@ -0,0 +1,46 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/task_scheduler/utils.h"
+
+#include "base/bind.h"
+#include "base/task_scheduler/priority_queue.h"
+#include "base/task_scheduler/task_tracker.h"
+
+namespace base {
+namespace internal {
+
+namespace {
+
+void PostTaskCallback(scoped_refptr<Sequence> sequence,
+                      PriorityQueue* priority_queue,
+                      scoped_ptr<Task> task) {
+  if (sequence->PushTask(std::move(task))) {
+    // |sequence| was empty before |task| was inserted into it. That means that
+    // |sequence| must be inserted in |priority_queue|.

[robliao, 2016/03/24 23:03:26]

I would reword the last sentence as...

Empty sequences are not part of any priority_queue, so it must be inserted. We
would normally DCHECK for this, but I don't see an easy non-invasive way of
scanning |priority_queue| without poking some holes and grabbing some locks.

[fdoray, 2016/03/29 18:33:34]

Done.

+    const SequenceSortKey sequence_sort_key = sequence->GetSortKey();
+    priority_queue->BeginTransaction()->Push(
+        make_scoped_ptr(new PriorityQueue::SequenceAndSortKey(
+            std::move(sequence), sequence_sort_key)));
+  }
+}
+
+}  // namespace
+
+void PostTaskHelper(scoped_ptr<Task> task,
+                    scoped_refptr<Sequence> sequence,
+                    PriorityQueue* priority_queue,
+                    TaskTracker* task_tracker) {
+  DCHECK(task);
+  DCHECK(sequence);
+  DCHECK(priority_queue);
+  DCHECK(task_tracker);
+
+  task_tracker->PostTask(
+      Bind(&PostTaskCallback, std::move(sequence), priority_queue),
+      std::move(task));
+}
+
+}  // namespace internal
+}  // namespace base