\r cleanup

\r cleanup

BUG=3034

[Dean McNamee, 2009-01-02 09:29:16]

Adding Tony and Aaron for JSON code.

[Aaron Boodman, 2009-01-04 04:35:15]

On 2009/01/02 09:29:16, Dean McNamee wrote:
> Adding Tony and Aaron for JSON code.

The change looks fine to me technically, but I'm not sure why we're changing
this. Was there some discussion for context?

[tony, 2009-01-05 01:49:11]

I think it should use the platform specific line endings (\r\n on windows, \n on
linux, whatever is the convention on osx).  The reader doesn't care about line
endings.

On 2009/01/04 04:35:15, Aaron Boodman wrote:
> On 2009/01/02 09:29:16, Dean McNamee wrote:
> > Adding Tony and Aaron for JSON code.
> 
> The change looks fine to me technically, but I'm not sure why we're changing
> this. Was there some discussion for context?

[Paweł Hajdan Jr., 2009-01-05 10:29:00]

For the general idea of this cleanup, please see
http://code.google.com/p/chromium/issues/detail?id=3034 .

So trace_event is quite straightforward here, but I'm not sure if I should
change JSON code at all. I can easily change it to have different line endings
depending on platform, just please check if changing this code (JSON) makes
sense.

[Erik does not do reviews, 2009-01-05 17:16:35]

As before, the trace_event change LGTM since the output isn't really intended to
be read by end-users anyway.

[tony, 2009-01-05 17:24:48]

I think the json writer output is intended to be read by users so it would be
nice to have it obey platform convention.  That said, it doesn't need to happen
in this change.

[Paweł Hajdan Jr., 2009-01-05 17:48:24]

I dropped json changes for now. I think it would have to be discussed how to do
it (I'm going to post some questions in the bug), but there is no reason to halt
the trace_event change.

[tony, 2009-01-05 17:55:46]

Sounds good to me!

On 2009/01/05 17:48:24, Paweł Hajdan Jr. wrote:
> I dropped json changes for now. I think it would have to be discussed how to
do
> it (I'm going to post some questions in the bug), but there is no reason to
halt
> the trace_event change.