Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 170403002: StyleSheetList::document() should return null after detaching the StyleSheetList from document. (Closed)

Created:
6 years, 10 months ago by tasak
Modified:
6 years, 10 months ago
Reviewers:
dglazkov
CC:
blink-reviews, dglazkov+blink, rune+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Visibility:
Public.

Description

StyleSheetList::document() should return null after detaching the StyleSheetList from document. BUG=337059 TEST=fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167581

Patch Set 1 #

Patch Set 2 : Added a layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
A LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + LayoutTests/fast/dom/shadow/access-document-of-detached-stylesheetlist-crash-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/css/StyleSheetList.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tasak
6 years, 10 months ago (2014-02-18 11:09:37 UTC) #1
dglazkov
lgtm
6 years, 10 months ago (2014-02-20 17:47:22 UTC) #2
tasak
On 2014/02/20 17:47:22, Dimitri Glazkov wrote: > lgtm Thank you for reviewing.
6 years, 10 months ago (2014-02-21 01:45:06 UTC) #3
tasak
The CQ bit was checked by tasak@google.com
6 years, 10 months ago (2014-02-21 01:45:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/170403002/90001
6 years, 10 months ago (2014-02-21 01:45:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 05:22:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=13456
6 years, 10 months ago (2014-02-21 05:22:12 UTC) #7
tasak
The CQ bit was checked by tasak@google.com
6 years, 10 months ago (2014-02-21 07:09:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/170403002/90001
6 years, 10 months ago (2014-02-21 07:09:22 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 08:15:45 UTC) #10
Message was sent while issue was closed. 
Change committed as 167581

Powered by Google App Engine
This is Rietveld 408576698