Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1703963003: Fix a crasher in CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a crasher in CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert() If a widget is barcode, we should set the data length of barcode as the max length of input string. BUG=pdfium:372 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d17a3af124c9e4fa218d5527910c0c9f22559a8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M xfa/src/fxfa/src/app/xfa_fftextedit.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
jun_fang
Hi Tom and Lei, Please start to review this CL. Thanks!
4 years, 10 months ago (2016-02-18 09:43:36 UTC) #4
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-18 19:43:56 UTC) #5
jun_fang
4 years, 10 months ago (2016-02-19 00:54:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d17a3af124c9e4fa218d5527910c0c9f22559a8f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698