add interp path

add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1703943003

Committed: https://skia.googlesource.com/skia/+/8e7b19d0f04f286ec283747ec128e9696c842858

[caryclark, 2016-02-17 20:35:42]

Description was changed from

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
==========

to

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2016-02-17 20:36:14]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 20:36:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703943003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703943003/1

[caryclark, 2016-02-17 20:37:22]

Please take a look. I'm not sure if this the correct division of labor between
path and path ref, or whether path ref editor was supposed to get in the middle.

[commit-bot: I haz the power, 2016-02-17 20:59:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 20:59:46]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-17 21:08:15]

Description was changed from

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-02-17 21:08:16]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-02-17 21:08:49]

Adding Brian. I believe the Path editor is supposed to be involved.

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:50: /** Interpolate between two paths with
indentically-sized point arrays.
conains ?

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode204
src/core/SkPath.cpp:204: if (memcmp(fPathRef->verbsMemBegin(),
compare.fPathRef->verbsMemBegin(),
line 'count' up with the '(' ?

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode207
src/core/SkPath.cpp:207: }
Shouldn't these be conicWeights not verbsMemBegin ?

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode208
src/core/SkPath.cpp:208: return !SkToBool(memcmp(fPathRef->verbsMemBegin(),
compare.fPathRef->verbsMemBegin(),
just countWeights() ?

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp#newcode3932
tests/PathTest.cpp:3932: p2.conicTo(7, 2, 7, 5, 1 / SkScalarSqrt(2));
add a test with a conic with the same points in each but different weights ?

[robertphillips, 2016-02-17 21:32:00]

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:49: 
identically ?

[caryclark, 2016-02-17 21:39:21]

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h
File include/core/SkPath.h (right):

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:49: 
On 2016/02/17 21:32:00, robertphillips wrote:
> identically ?

If I can't spell it, I shouldn't use it (done)

https://codereview.chromium.org/1703943003/diff/1/include/core/SkPath.h#newco...
include/core/SkPath.h:50: /** Interpolate between two paths with
indentically-sized point arrays.
On 2016/02/17 21:08:49, robertphillips wrote:
> conains ?

Done.

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode204
src/core/SkPath.cpp:204: if (memcmp(fPathRef->verbsMemBegin(),
compare.fPathRef->verbsMemBegin(),
On 2016/02/17 21:08:49, robertphillips wrote:
> line 'count' up with the '(' ?

Done.

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode207
src/core/SkPath.cpp:207: }
On 2016/02/17 21:08:49, robertphillips wrote:
> Shouldn't these be conicWeights not verbsMemBegin ?

Aack! I blame ctrl-v. (Done)

https://codereview.chromium.org/1703943003/diff/1/src/core/SkPath.cpp#newcode208
src/core/SkPath.cpp:208: return !SkToBool(memcmp(fPathRef->verbsMemBegin(),
compare.fPathRef->verbsMemBegin(),
On 2016/02/17 21:08:49, robertphillips wrote:
> just countWeights() ?

Done.

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp#newcode3932
tests/PathTest.cpp:3932: p2.conicTo(7, 2, 7, 5, 1 / SkScalarSqrt(2));
On 2016/02/17 21:08:49, robertphillips wrote:
> add a test with a conic with the same points in each but different weights ?

I intentionally didn't address this. I don't know what it means to animate the
weight, but I don't think it is a linear exercise. Also, when the weight goes to
one, the path stores a quadratic instead of a conic, so interpolation goes to
pot.

[bsalomon, 2016-02-17 21:43:43]

I think the editor should be involved because IIRC it invalidates the genID

[caryclark, 2016-02-17 21:47:07]

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp
File tests/PathTest.cpp (right):

https://codereview.chromium.org/1703943003/diff/1/tests/PathTest.cpp#newcode3932
tests/PathTest.cpp:3932: p2.conicTo(7, 2, 7, 5, 1 / SkScalarSqrt(2));
I misunderstood the feedback. I added a test that checks to see if only the
conic weight is different, and fails in that case. (done)

[caryclark, 2016-02-17 21:47:15]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 21:47:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703943003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703943003/60001

[bsalomon, 2016-02-17 22:00:37]

On 2016/02/17 21:47:22, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1703943003/60001
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1703943003/60001

Cary pointed out that the reset will inval, lgtm

[caryclark, 2016-02-17 22:01:57]

On 2016/02/17 21:43:43, bsalomon wrote:
> I think the editor should be involved because IIRC it invalidates the genID

Since out->reset() is called, the genID and friends all get set up without
invoking the Editor directly

[robertphillips, 2016-02-17 22:08:53]

lgtm

[commit-bot: I haz the power, 2016-02-17 22:22:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 22:22:35]

Dry run: This issue passed the CQ dry run.

[caryclark, 2016-02-18 12:10:56]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-02-18 12:11:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703943003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703943003/60001

[commit-bot: I haz the power, 2016-02-18 12:11:52]

Description was changed from

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
add interp path

Add path methods to determine if a pair of paths
can be interpolated, and to interpolate them.

R=reed@google.com, robertphillips@google.com
BUG=skia:4549
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/8e7b19d0f04f286ec283747ec128e9696c842858
==========

[commit-bot: I haz the power, 2016-02-18 12:11:54]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8e7b19d0f04f286ec283747ec128e9696c842858