Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 1703903002: Editing: Remove unreasonable ASSERT_NO_EDITING_ABORT instances. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Editing: Remove unreasonable ASSERT_NO_EDITING_ABORT instances. This CL has no tests. We're not sure if this CL makes user-visible behavior changes. The purpose of this CL is to reduce ClusterFuzz crashes in the future. This CL also updates comments in EditingState.h. We can't remove NoEditingAbortChecker and ASSERT_NO_EDITING_ABORT. BUG=586846 Committed: https://crrev.com/8fb3a4aee13f5299f4fb27d879b1fd1f07a5ae15 Cr-Commit-Position: refs/heads/master@{#376067}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditingState.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/SimplifyMarkupCommand.cpp View 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
yosin@, would you review this please?
4 years, 10 months ago (2016-02-18 01:14:26 UTC) #2
yosin_UTC9
lgtm
4 years, 10 months ago (2016-02-18 01:27:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703903002/1
4 years, 10 months ago (2016-02-18 01:28:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 02:19:34 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:21:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fb3a4aee13f5299f4fb27d879b1fd1f07a5ae15
Cr-Commit-Position: refs/heads/master@{#376067}

Powered by Google App Engine
This is Rietveld 408576698