Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(890)

Issue 1703883002: Eagerly unregister PostMessageTimer as a context observer. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eagerly unregister PostMessageTimer as a context observer. The effective lifetime of a PostMessageTimer is over once its callback fires; unregister as an observer at that point to avoid unnecessary work during the following GC. R=haraken BUG=587012 Committed: https://crrev.com/28cbfe3c734e290ab440f2f25e9cfee757956fa8 Cr-Commit-Position: refs/heads/master@{#375885}

Patch Set 1 #

Patch Set 2 : compile fix #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 5 chunks +23 lines, -16 lines 3 comments Download

Messages

Total messages: 13 (6 generated)
sof
please take a look. It clearly won't address arbitrary buildup of messages to suspended windows ...
4 years, 10 months ago (2016-02-17 13:30:47 UTC) #2
haraken
LGTM https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp#newcode157 third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed = false; How about moving this line ...
4 years, 10 months ago (2016-02-17 13:52:37 UTC) #4
sof
https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp#newcode157 third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed = false; On 2016/02/17 13:52:37, haraken wrote: > ...
4 years, 10 months ago (2016-02-17 13:55:40 UTC) #5
haraken
https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right): https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp#newcode157 third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed = false; On 2016/02/17 13:55:40, sof wrote: > ...
4 years, 10 months ago (2016-02-17 13:57:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703883002/20001
4 years, 10 months ago (2016-02-17 15:05:15 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 15:12:42 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 15:13:49 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28cbfe3c734e290ab440f2f25e9cfee757956fa8
Cr-Commit-Position: refs/heads/master@{#375885}

Powered by Google App Engine
This is Rietveld 408576698