Eagerly unregister PostMessageTimer as a context observer.

Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012
Committed: https://crrev.com/28cbfe3c734e290ab440f2f25e9cfee757956fa8
Cr-Commit-Position: refs/heads/master@{#375885}

[sof, 2016-02-17 13:30:47]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2016-02-17 13:30:47]

please take a look.

It clearly won't address arbitrary buildup of messages to suspended windows
(debugger paused?), but a small thing worth doing regardless.

[haraken, 2016-02-17 13:52:36]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2016-02-17 13:52:37]

LGTM

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed =
false;

How about moving this line into dispose()?

[sof, 2016-02-17 13:55:40]

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed =
false;
On 2016/02/17 13:52:37, haraken wrote:
> 
> How about moving this line into dispose()?

I don't see how that's possible given that we want to neutralize event handlers
calling stop().

[haraken, 2016-02-17 13:57:19]

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp (right):

https://codereview.chromium.org/1703883002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp:157: m_disposalAllowed =
false;
On 2016/02/17 13:55:40, sof wrote:
> On 2016/02/17 13:52:37, haraken wrote:
> > 
> > How about moving this line into dispose()?
> 
> I don't see how that's possible given that we want to neutralize event
handlers
> calling stop().

Makes sense.

[sof, 2016-02-17 15:04:34]

Description was changed from

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=
BUG=587012
==========

to

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012
==========

[sof, 2016-02-17 15:04:38]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2016-02-17 15:05:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1703883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1703883002/20001

[commit-bot: I haz the power, 2016-02-17 15:12:41]

Description was changed from

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012
==========

to

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012
==========

[commit-bot: I haz the power, 2016-02-17 15:12:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-17 15:13:49]

Description was changed from

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012
==========

to

==========
Eagerly unregister PostMessageTimer as a context observer.

The effective lifetime of a PostMessageTimer is over once its callback
fires; unregister as an observer at that point to avoid unnecessary work
during the following GC.

R=haraken
BUG=587012

Committed: https://crrev.com/28cbfe3c734e290ab440f2f25e9cfee757956fa8
Cr-Commit-Position: refs/heads/master@{#375885}
==========

[commit-bot: I haz the power, 2016-02-17 15:13:49]

Patchset 2 (id:??) landed as
https://crrev.com/28cbfe3c734e290ab440f2f25e9cfee757956fa8
Cr-Commit-Position: refs/heads/master@{#375885}