Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 1703853002: [Swarming] Add missing files to gcmole isolate. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Add missing files to gcmole isolate. BUG=chromium:535160 LOG=n TBR=tandrii@chromium.org, kjellander@chromium.org NOTRY=true Committed: https://crrev.com/a08701cb0f891fd5f189aa57be11cf255e713d5d Cr-Commit-Position: refs/heads/master@{#34075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/gcmole/run-gcmole.isolate View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
TBR
4 years, 10 months ago (2016-02-17 12:49:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1703853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1703853002/1
4 years, 10 months ago (2016-02-17 12:49:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 12:50:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a08701cb0f891fd5f189aa57be11cf255e713d5d Cr-Commit-Position: refs/heads/master@{#34075}
4 years, 10 months ago (2016-02-17 12:51:09 UTC) #9
kjellander_chromium
I think you might be missing some still ;) (https://codereview.chromium.org/1706783002/) lgtm
4 years, 10 months ago (2016-02-17 13:36:11 UTC) #10
Michael Achenbach
4 years, 10 months ago (2016-02-17 13:37:10 UTC) #11
Message was sent while issue was closed.
hehe - yea - easy to say now :)

Powered by Google App Engine
This is Rietveld 408576698