Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/extensions/token_cache/token_cache_service.h

Issue 170383005: Move TokenCacheService away from listening for Signin notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/token_cache/token_cache_service.h
diff --git a/chrome/browser/extensions/token_cache/token_cache_service.h b/chrome/browser/extensions/token_cache/token_cache_service.h
index bab555e46af95f3d8e9acd6bf2664b9f925838c9..d3dc6ea25ffb0d9475138109d620af28cd944e4b 100644
--- a/chrome/browser/extensions/token_cache/token_cache_service.h
+++ b/chrome/browser/extensions/token_cache/token_cache_service.h
@@ -11,13 +11,8 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "base/time/time.h"
+#include "chrome/browser/signin/signin_manager_base.h"
#include "components/browser_context_keyed_service/browser_context_keyed_service.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-
-namespace content {
-class NotificationSource;
-}
class Profile;
@@ -27,7 +22,7 @@ namespace extensions {
// when the user logs out or after the specified timeout interval, or when
// the instance of chrome shuts down.
class TokenCacheService : public BrowserContextKeyedService,
- public content::NotificationObserver {
+ public SigninManagerBase::Observer {
public:
explicit TokenCacheService(Profile* profile);
virtual ~TokenCacheService();
@@ -43,13 +38,12 @@ class TokenCacheService : public BrowserContextKeyedService,
// string if the token was not found or timed out.
std::string RetrieveToken(const std::string& token_name);
- // Inherited from NotificationObserver.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
private:
friend class TokenCacheTest;
+ FRIEND_TEST_ALL_PREFIXES(TokenCacheTest, SignoutTest);
+
+ // SigninManagerBase::Observer:
+ virtual void GoogleSignedOut(const std::string& username) OVERRIDE;
struct TokenCacheData {
std::string token;
@@ -58,7 +52,6 @@ class TokenCacheService : public BrowserContextKeyedService,
// Map the token name (string) to token data.
std::map<std::string, TokenCacheData> token_cache_;
- content::NotificationRegistrar registrar_;
const Profile* const profile_;
DISALLOW_COPY_AND_ASSIGN(TokenCacheService);

Powered by Google App Engine
This is Rietveld 408576698