Issue 170383005: Move TokenCacheService away from listening for Signin notifications.

Issue 170383005: Move TokenCacheService away from listening for Signin notifications. (Closed)

Created:
6 years, 10 months ago by blundell

Modified:
6 years, 10 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Move TokenCacheService away from listening for Signin notifications. This change is part of eliminating the signin-related notifications in favor of having clients observe SigninManager. BUG=333997 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252088

Patch Set 1 #

Patch Set 2 : Nit #

Total comments: 2

Patch Set 3 : Respond to review #

Patch Set 4 : Call Shutdown() in unit test #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -31 lines)			Patch
M	chrome/browser/extensions/token_cache/token_cache_service.h	View	1 2	4 chunks	+8 lines, -12 lines	0 comments	Download
M	chrome/browser/extensions/token_cache/token_cache_service.cc	View	1 2	3 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/token_cache/token_cache_service_factory.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/token_cache/token_cache_service_unittest.cc	View	1 2 3	4 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Yoyo Zhou

https://codereview.chromium.org/170383005/diff/30001/chrome/browser/extensions/token_cache/token_cache_service.cc File chrome/browser/extensions/token_cache/token_cache_service.cc (right): https://codereview.chromium.org/170383005/diff/30001/chrome/browser/extensions/token_cache/token_cache_service.cc#newcode20 chrome/browser/extensions/token_cache/token_cache_service.cc:20: SigninManagerFactory::GetForProfile(const_cast<Profile*>(profile_)) This should be in TokenCacheService::Shutdown. Also declare in ...

6 years, 10 months ago (2014-02-18 17:45:53 UTC) #2

blundell

https://codereview.chromium.org/170383005/diff/30001/chrome/browser/extensions/token_cache/token_cache_service.cc File chrome/browser/extensions/token_cache/token_cache_service.cc (right): https://codereview.chromium.org/170383005/diff/30001/chrome/browser/extensions/token_cache/token_cache_service.cc#newcode20 chrome/browser/extensions/token_cache/token_cache_service.cc:20: SigninManagerFactory::GetForProfile(const_cast<Profile*>(profile_)) Great catches, thanks. Done. On 2014/02/18 17:45:54, Yoyo ...

6 years, 10 months ago (2014-02-18 19:53:42 UTC) #3