Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 170383003: Merge a few A64 utils into the CompilerIntrinsics.

Created:
6 years, 10 months ago by Alexandre Rames
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge a few A64 utils into the CompilerIntrinsics.

Patch Set 1 #

Patch Set 2 : Fixes and cleaning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -180 lines) Patch
M src/a64/simulator-a64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/a64/utils-a64.h View 1 chunk +4 lines, -5 lines 0 comments Download
D src/a64/utils-a64.cc View 1 chunk +0 lines, -112 lines 0 comments Download
M src/compiler-intrinsics.h View 1 3 chunks +178 lines, -7 lines 0 comments Download
A + src/compiler-intrinsics.cc View 1 3 chunks +7 lines, -53 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexandre Rames
This has *not* been tested on Windows as we don't have a Windows box. Do ...
6 years, 10 months ago (2014-02-18 14:22:47 UTC) #1
jochen (gone - plz use gerrit)
On 2014/02/18 14:22:47, Alexandre Rames wrote: > This has *not* been tested on Windows as ...
6 years, 10 months ago (2014-02-19 17:31:34 UTC) #2
jochen (gone - plz use gerrit)
it doesn't compile: http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/29/steps/compile/logs/stdio http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/24/steps/compile/logs/stdio
6 years, 10 months ago (2014-02-19 18:02:11 UTC) #3
Alexandre Rames
On 2014/02/19 18:02:11, jochen wrote: > it doesn't compile: > > http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/29/steps/compile/logs/stdio > http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/24/steps/compile/logs/stdio Fixing ...
6 years, 10 months ago (2014-02-20 11:24:25 UTC) #4
Alexandre Rames
There are three main points to the updated patch: 1) Split functions more clearly. There ...
6 years, 10 months ago (2014-02-20 15:34:02 UTC) #5
jochen (gone - plz use gerrit)
I don't think I'm a good reviewer for this patch. I ran it on the ...
6 years, 10 months ago (2014-02-25 19:52:20 UTC) #6
Alexandre Rames
6 years, 10 months ago (2014-02-26 09:36:49 UTC) #7
On 2014/02/25 19:52:20, jochen wrote:
> I don't think I'm a good reviewer for this patch.
> 
> I ran it on the trybots anyway, however, it still doesn't build:
> 
>
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/25/steps/...
>
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel/builds/30/steps/...

Ok I think that's enough trying without being actually able to test locally.
Sorry about that.
I'll see if I can get some local setup to compile the whole project on OSX and
Windows.

Powered by Google App Engine
This is Rietveld 408576698