Source/core/dom/shadow/ElementShadow.cpp - Issue 17038004: Remove needsShadowTreeWalker flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/shadow/ElementShadow.cpp

Issue 17038004: Remove needsShadowTreeWalker flag (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/shadow/ElementShadow.cpp

diff --git a/Source/core/dom/shadow/ElementShadow.cpp b/Source/core/dom/shadow/ElementShadow.cpp

index ec30bd6535872d8ca0034ea802178af075185b1e..b0e71f1ceff88ba0cf5728e1c65b361df6e86e26 100644

--- a/Source/core/dom/shadow/ElementShadow.cpp

+++ b/Source/core/dom/shadow/ElementShadow.cpp

@@ -41,12 +41,6 @@ ShadowRoot* ElementShadow::addShadowRoot(Element* shadowHost, ShadowRoot::Shadow

m_distributor.didShadowBoundaryChange(shadowHost);

ChildNodeInsertionNotifier(shadowHost).notify(shadowRoot.get());

- // Existence of shadow roots requires the host and its children to do traversal using ComposedShadowTreeWalker.

- shadowHost->setNeedsShadowTreeWalker();

- // FIXME(94905): ShadowHost should be reattached during recalcStyle.

dominicc (has gone to gerrit) 2013/06/14 02:12:52 Why is it OK for the FIXME to die?

- // Set some flag here and recreate shadow hosts' renderer in

- // Element::recalcStyle.

if (shadowHost->attached())

shadowHost->lazyReattach();

« no previous file with comments | « Source/core/dom/NodeRenderingTraversal.cpp ('k') | Source/core/dom/shadow/InsertionPoint.h » ('j') | no next file with comments »