Issue 17038004: Remove needsShadowTreeWalker flag

Issue 17038004: Remove needsShadowTreeWalker flag (Closed)

Created:
7 years, 6 months ago by esprehn

Modified:
7 years, 6 months ago

Reviewers:
Hajime Morrita, dominicc (has gone to gerrit)

CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, chromiumbugtracker_adobe.com

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove needsShadowTreeWalker flag The "fast path" in NodeRenderingTraversal is a source of bugs and didn't show to be much of an optimization for Blink. We should just remove it per the discussion in https://codereview.chromium.org/14731014/#msg8 BUG=229245 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152408

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -95 lines)			Patch
M	Source/core/dom/ContainerNode.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/core/dom/Element.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	3 chunks	+2 lines, -13 lines	0 comments	Download
M	Source/core/dom/ElementRareData.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/dom/Node.h	View	3 chunks	+5 lines, -11 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	Source/core/dom/NodeRenderingTraversal.h	View	2 chunks	+0 lines, -43 lines	0 comments	Download
M	Source/core/dom/NodeRenderingTraversal.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/dom/shadow/ElementShadow.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/dom/shadow/InsertionPoint.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

dominicc (has gone to gerrit)

LGTM https://codereview.chromium.org/17038004/diff/1/Source/core/dom/shadow/ElementShadow.cpp File Source/core/dom/shadow/ElementShadow.cpp (left): https://codereview.chromium.org/17038004/diff/1/Source/core/dom/shadow/ElementShadow.cpp#oldcode47 Source/core/dom/shadow/ElementShadow.cpp:47: // FIXME(94905): ShadowHost should be reattached during recalcStyle. ...

7 years, 6 months ago (2013-06-14 02:12:52 UTC) #2

esprehn

On 2013/06/14 02:12:52, dominicc wrote: > LGTM > > https://codereview.chromium.org/17038004/diff/1/Source/core/dom/shadow/ElementShadow.cpp > File Source/core/dom/shadow/ElementShadow.cpp (left): > ...

7 years, 6 months ago (2013-06-14 02:16:04 UTC) #3

esprehn

On 2013/06/14 02:16:04, esprehn wrote: >.. > https://codereview.chromium.org/17038004/diff/1/Source/core/dom/shadow/ElementShadow.cpp#oldcode47 > > Source/core/dom/shadow/ElementShadow.cpp:47: // FIXME(94905): ShadowHost > ...

7 years, 6 months ago (2013-06-14 02:16:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/17038004/1

7 years, 6 months ago (2013-06-14 02:17:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/17038004/13001

7 years, 6 months ago (2013-06-14 02:38:06 UTC) #7

Message was sent while issue was closed.

Change committed as 152408

Expand Messages | Collapse Messages