Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: chrome/browser/extensions/install_tracker.cc

Issue 17038002: Separate the NTP app ordering from the app list app ordering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add migration from NTP sorting Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/install_tracker.cc
diff --git a/chrome/browser/extensions/install_tracker.cc b/chrome/browser/extensions/install_tracker.cc
index 1212c5b71c6515c31312064f7c05bfd9d038c1ca..3888da33ed3fefd4c7ea0e1144ba5013debb0f92 100644
--- a/chrome/browser/extensions/install_tracker.cc
+++ b/chrome/browser/extensions/install_tracker.cc
@@ -14,7 +14,7 @@ namespace extensions {
InstallTracker::InstallTracker(Profile* profile,
extensions::ExtensionPrefs* prefs) {
- ExtensionSorting* sorting = prefs->extension_sorting();
+ AppListExtensionSorting* ordering = prefs->app_list_extension_sorting();
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_INSTALLED,
content::Source<Profile>(profile));
@@ -22,16 +22,16 @@ InstallTracker::InstallTracker(Profile* profile,
content::Source<Profile>(profile));
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED,
content::Source<Profile>(profile));
+ registrar_.Add(this, chrome::NOTIFICATION_APP_LIST_REORDERED,
+ content::Source<AppListExtensionSorting>(ordering));
registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNINSTALLED,
content::Source<Profile>(profile));
- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED,
- content::Source<ExtensionSorting>(sorting));
registrar_.Add(this, chrome::NOTIFICATION_APP_INSTALLED_TO_APPLIST,
content::Source<Profile>(profile));
pref_change_registrar_.Init(prefs->pref_service());
pref_change_registrar_.Add(extensions::ExtensionPrefs::kExtensionsPref,
- base::Bind(&InstallTracker::OnAppsReordered,
+ base::Bind(&InstallTracker::OnAppListReordered,
base::Unretained(this)));
}
@@ -111,8 +111,8 @@ void InstallTracker::Observe(int type,
OnExtensionUninstalled(extension));
break;
}
- case chrome::NOTIFICATION_EXTENSION_LAUNCHER_REORDERED: {
- FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppsReordered());
+ case chrome::NOTIFICATION_APP_LIST_REORDERED: {
+ FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppListReordered());
break;
}
case chrome::NOTIFICATION_APP_INSTALLED_TO_APPLIST: {
@@ -127,8 +127,8 @@ void InstallTracker::Observe(int type,
}
}
-void InstallTracker::OnAppsReordered() {
- FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppsReordered());
+void InstallTracker::OnAppListReordered() {
+ FOR_EACH_OBSERVER(InstallObserver, observers_, OnAppListReordered());
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698