Separate the NTP app ordering from the app list app ordering

chrome/browser/sync/test/integration/two_client_apps_sync_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_sorting.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/profile_sync_service_harness.h"
 #include "chrome/browser/sync/test/integration/apps_helper.h"
@@ skipping 404 matching lines @@
   GetProfile(1)->GetExtensionService()->extension_prefs()->
       extension_sorting()->SetPageOrdinal(extension_misc::kWebStoreAppId,
                                           cws_page_ordinal.CreateAfter());
   verifier()->GetExtensionService()->extension_prefs()->
       extension_sorting()->SetPageOrdinal(extension_misc::kWebStoreAppId,
                                           cws_page_ordinal.CreateAfter());
   ASSERT_TRUE(AwaitQuiescence());
   ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
 }
 
+// Adjust the chrome app location within the app list on the first client and
+// sync. Both clients should have the same app list ordinal values for the
+// chrome app.
+IN_PROC_BROWSER_TEST_F(TwoClientAppsSyncTest, UpdateChromeAppAppListOrdinal) {
+  ASSERT_TRUE(SetupSync());
+  ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
+
+  // Change the app list ordinal.
+  AppListExtensionOrdering* ordering =
+      GetProfile(0)->GetExtensionService()->extension_prefs()->
+          app_list_extension_ordering();
+  AppListExtensionOrdering* verifier_ordering =
+      verifier()->GetExtensionService()->extension_prefs()->
+          app_list_extension_ordering();
+  ordering->Erase(extension_misc::kChromeAppId);
+  verifier_ordering->Erase(extension_misc::kChromeAppId);
+  ordering->InsertAtNextAvailable(extension_misc::kChromeAppId);
+  verifier_ordering->InsertAtNextAvailable(extension_misc::kChromeAppId);

[koz (OOO until 15th September), 2013/06/18 07:41:36]

This might read better like

MoveChromeAppToEnd(ordering);
MoveChromeAppToEnd(verifier_ordering);

[calamity, 2013/06/19 05:09:17]

Done.

+  ASSERT_TRUE(AwaitQuiescence());
+  ASSERT_TRUE(AllProfilesHaveSameAppsAsVerifier());
+}
+
 // TODO(akalin): Add tests exercising:
 //   - Offline installation/uninstallation behavior
 //   - App-specific properties