MD Settings: Manage search engines, localizing/adding strings.

chrome/app/settings_strings.grdp

Index: chrome/app/settings_strings.grdp
diff --git a/chrome/app/settings_strings.grdp b/chrome/app/settings_strings.grdp
index 117085ed0feb5a6f68ca8b977463a1a72bd95025..0e255494b6759717cf79110371101a2166667d33 100644
--- a/chrome/app/settings_strings.grdp
+++ b/chrome/app/settings_strings.grdp
@@ -439,8 +439,8 @@
   <message name="IDS_SETTINGS_SEARCH_EXPLANATION" desc="Explanation for the search engine dropdown setting.">
     Search engine used when searching from the omnibox
   </message>
-  <message name="IDS_SETTINGS_SEARCH_MANAGE_BUTTON_LABEL" desc="Label for the Manage Search Engines button.">
-    Manage Search Engines
+  <message name="IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES" desc="Label for the Manage Search Engines button.">

[Dan Beam, 2016/02/16 23:45:17]

why why IDS_SETTINGS_SEARCH_MANAGE_MANAGE_SEARCH_ENGINES ? ?

[dpapad, 2016/02/17 00:00:17]

By accident, fixed.

+    Manage search engines

[Dan Beam, 2016/02/16 23:45:17]

are the mocks not title case?  also, I assume most of this moot as THE BUTTONS
LOOK LIKE THIS?

[dpapad, 2016/02/17 00:00:17]

This string is used twice,
1) As "MANAGE SEARCH ENGINES" to open the search engines page (meant to be
capitalized by CSS text transform).
2) As "Manage search engines" as the title of the (animated) page.

Title case is not used anywhere in the mocks for this particular string.

[Dan Beam, 2016/02/17 00:07:30]

sweet, thanks for explaining

   </message>
   <message name="IDS_SETTINGS_SEARCH_OK_GOOGLE_LABEL" desc="Label for the checkbox which enables the OK Google hotword.">
     Enable "Ok Google" to start a voice search.
@@ -456,26 +456,32 @@
   <message name="IDS_SETTINGS_SEARCH_ENGINES" desc="Name of the settings page which manages search engines.">
     Search Engines
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_ADD_SEARCH_ENGINE_LABEL" desc="Label for section for adding a new search engine.">
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_ADD_A_SEARCH_ENGINE" desc="Label for section for adding a new search engine.">
     Add a search engine
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_LABEL" desc="Label for regular Search Engines section">
-    Search engines
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_ADD_SEARCH_ENGINE" desc="Title for a dialog that allows adding a new search engine.">
+    Add search engine
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES_LABEL" desc="Label for 'other' Search Engines section">
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_EDIT_SEARCH_ENGINE" desc="Title for a dialog that allows editing an existing search engine.">
+    Edit search engine
+  </message>
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_NOT_VALID" desc="Text indicating that the input to a given text field is invalid.">

[Dan Beam, 2016/02/16 23:45:17]

maybe make this search engines specific as well

[dpapad, 2016/02/17 00:00:17]

Done.

+   Not valid
+  </message>
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES" desc="Label for 'other' Search Engines section">
     Other search engines
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE_LABEL" desc="Label for a table column that holds the name of a search engine">
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_SEARCH_ENGINE" desc="Label for a table column that holds the name of a search engine">
     Search engine
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_KEYWORD_LABEL" desc="Label for Keyword column header for a search engine">
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_KEYWORD" desc="Label for Keyword column header for a search engine">
     Keyword
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_LABEL" desc="Label for Query URL column header for a search engine">
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL" desc="Label for Query URL column header for a search engine">
     Query URL
   </message>
-  <message name="IDS_SETTINGS_SEARCH_ENGINES_ADD" desc="Label for Add button for adding a new search engine">
-    Add
+  <message name="IDS_SETTINGS_SEARCH_ENGINES_QUERY_URL_EXPLANATION" desc="Label for explaining the format of the URL that should be entered by the user.">

[Dan Beam, 2016/02/16 23:45:17]

mention that this is in the search engines page somehow (like the previous
description)

[dpapad, 2016/02/17 00:00:17]

Done.

+    URL with %s in place of query
   </message>
   <message name="IDS_SETTINGS_SEARCH_ENGINES_MAKE_DEFAULT" desc="Text of the button that makes the selected engine the default search engine">
     Make default