PRESUBMIT.py - Issue 1703663002: Port Skia recipe to normal Python scripts, move to Skia repo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 1703663002: Port Skia recipe to normal Python scripts, move to Skia repo (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Move everything into infra/bots, fix readme, fix presubmit Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 326caad1e8a1fbd915a158ba127ceca2cf6640ff..df2b5737b834d7a932f6177e76024dce9b14031a 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -85,6 +85,7 @@ def _PythonChecks(input_api, output_api):

'R0201', # Method could be a function.

'E1003', # Using class name in super.

'W0613', # Unused argument.

+ 'W0105', # String statement has no effect.

rmistry 2016/02/18 15:29:21 Out of curiosity, where did you run into this?

borenet 2016/02/18 15:40:56 All of the module and function level docstrings tr

)

# Run Pylint on only the modified python files. Unfortunately it still runs

# Pylint on the whole file instead of just the modified lines.

« no previous file with comments | « no previous file | infra/bots/README.md » ('j') | infra/bots/common.py » ('J')